Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1598)

Unified Diff: appengine/findit/crash/test/project_classifier_test.py

Issue 2562623004: Making CallStack immutable, so it can be hashable (Closed)
Patch Set: Addressing nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/test/occurrence_test.py ('k') | appengine/findit/crash/test/stacktrace_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/test/project_classifier_test.py
diff --git a/appengine/findit/crash/test/project_classifier_test.py b/appengine/findit/crash/test/project_classifier_test.py
index 234c15b6f80445048e39608f089ef65aee40429b..89fd47262e21dc682330b27047dfe7f4958626d3 100644
--- a/appengine/findit/crash/test/project_classifier_test.py
+++ b/appengine/findit/crash/test/project_classifier_test.py
@@ -63,12 +63,10 @@ class ProjectClassifierTest(CrashTestCase):
def testClassifyCrashStack(self):
classifier = ProjectClassifier()
- crash_stack = CallStack(0)
- crash_stack.extend([
+ crash_stack = CallStack(0, frame_list=[
StackFrame(0, 'src/', 'func', 'comp1.cc', 'src/comp1.cc', [2]),
StackFrame(1, 'src/', 'ff', 'comp1.cc', 'src/comp1.cc', [21]),
- StackFrame(2, 'src/', 'func2', 'comp2.cc', 'src/comp2.cc', [8])
- ])
+ StackFrame(2, 'src/', 'func2', 'comp2.cc', 'src/comp2.cc', [8])])
self.assertEqual(classifier.Classify([], crash_stack), 'chromium')
@@ -105,15 +103,16 @@ class ProjectClassifierTest(CrashTestCase):
def testClassifyForJavaRankFunction(self):
classifier = ProjectClassifier()
- crash_stack = CallStack(0)
- crash_stack.language_type = CallStackLanguageType.JAVA
+ crash_stack = CallStack(0, language_type=CallStackLanguageType.JAVA)
- crash_stack.extend([
- StackFrame(0, '', 'android.a.f', 'android/a/cc',
- 'android/a.java', [2]),
- StackFrame(1, '', 'org.chromium.c', 'org/chromium/c.java',
- 'org/chromium/c.java', [8])
- ])
+ crash_stack = CallStack(0,
+ language_type=CallStackLanguageType.JAVA,
+ frame_list=[
+ StackFrame(0, '', 'android.a.f', 'android/a/cc',
+ 'android/a.java', [2]),
+ StackFrame(1, '', 'org.chromium.c', 'org/chromium/c.java',
+ 'org/chromium/c.java', [8])
+ ])
self.assertEqual(classifier.Classify([], crash_stack),
'chromium')
@@ -129,12 +128,10 @@ class ProjectClassifierTest(CrashTestCase):
crash_config.project_classifier = {}
crash_config.put()
- crash_stack = CallStack(0)
- crash_stack.extend([
+ crash_stack = CallStack(0, frame_list=[
StackFrame(0, 'src/', 'func', 'comp1.cc', 'src/comp1.cc', [2]),
StackFrame(1, 'src/', 'ff', 'comp1.cc', 'src/comp1.cc', [21]),
- StackFrame(2, 'src/', 'func2', 'comp2.cc', 'src/comp2.cc', [8])
- ])
+ StackFrame(2, 'src/', 'func2', 'comp2.cc', 'src/comp2.cc', [8])])
result1 = Result(self.GetDummyChangeLog(), 'src/')
result1.file_to_stack_infos = {
« no previous file with comments | « appengine/findit/crash/test/occurrence_test.py ('k') | appengine/findit/crash/test/stacktrace_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698