Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1817)

Unified Diff: appengine/findit/crash/test/occurrence_test.py

Issue 2562623004: Making CallStack immutable, so it can be hashable (Closed)
Patch Set: Addressing nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/occurrence_test.py
diff --git a/appengine/findit/crash/test/occurrence_test.py b/appengine/findit/crash/test/occurrence_test.py
index f89b45c97f60828a97c15ce71accf75cc9a25c1a..d85c78211573320dba1df9105ceef9f03610342c 100644
--- a/appengine/findit/crash/test/occurrence_test.py
+++ b/appengine/findit/crash/test/occurrence_test.py
@@ -29,7 +29,8 @@ class DummyClassifier(object):
if results:
classes = map(self.GetClassFromResult, results[:top_n_frames])
else:
- classes = map(self.GetClassFromStackFrame, crash_stack[:top_n_frames])
+ classes = map(self.GetClassFromStackFrame,
+ crash_stack.frames[:top_n_frames])
class_list = RankByOccurrence(classes, 1)
if class_list:
@@ -52,18 +53,17 @@ class ClassifierTest(CrashTestCase):
crash_stack = CallStack(0)
self.assertEqual(dummy_classifier.Classify([], crash_stack), '')
- crash_stack.extend(
- [StackFrame(0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]),
- StackFrame(1, 'src/', 'a::d(a* c)', 'f1.cc', 'src/f1.cc', [227]),
- StackFrame(2, 'src/dummy', 'a::e(int)', 'f2.cc', 'src/f2.cc', [87])])
+ crash_stack = CallStack(0, frame_list=[
+ StackFrame(0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]),
+ StackFrame(1, 'src/', 'a::d(a* c)', 'f1.cc', 'src/f1.cc', [227]),
+ StackFrame(2, 'src/dummy', 'a::e(int)', 'f2.cc', 'src/f2.cc', [87])])
self.assertEqual(dummy_classifier.Classify([], crash_stack), 'class_1')
- crash_stack = CallStack(0)
- crash_stack.extend(
- [StackFrame(0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]),
- StackFrame(1, 'src/dummy', 'a::d(a* c)', 'f1.cc', 'src/f1.cc', [227]),
- StackFrame(2, 'src/dummy', 'a::e(int)', 'f2.cc', 'src/f2.cc', [87])])
+ crash_stack = CallStack(0, frame_list=[
+ StackFrame(0, 'src/', 'a::c(p* &d)', 'f0.cc', 'src/f0.cc', [177]),
+ StackFrame(1, 'src/dummy', 'a::d(a* c)', 'f1.cc', 'src/f1.cc', [227]),
+ StackFrame(2, 'src/dummy', 'a::e(int)', 'f2.cc', 'src/f2.cc', [87])])
self.assertEqual(dummy_classifier.Classify([], crash_stack), 'class_2')
« no previous file with comments | « appengine/findit/crash/test/component_classifier_test.py ('k') | appengine/findit/crash/test/project_classifier_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698