appengine/findit/crash/project_classifier.py - Issue 2562623004: Making CallStack immutable, so it can be hashable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/crash/project_classifier.py

Issue 2562623004: Making CallStack immutable, so it can be hashable (Closed)

Patch Set: Addressing nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/crash/project_classifier.py

diff --git a/appengine/findit/crash/project_classifier.py b/appengine/findit/crash/project_classifier.py

index 9e4e47bcee62ba263ae2a687680d3314e32c531a..5cc9d9428e2a9439f97780fcdb0e63700a3733fc 100644

--- a/appengine/findit/crash/project_classifier.py

+++ b/appengine/findit/crash/project_classifier.py

@@ -107,7 +107,8 @@ class ProjectClassifier(object):

if results:

classes = map(self.GetClassFromResult, results[:top_n_frames])

else:

- classes = map(self.GetClassFromStackFrame, crash_stack[:top_n_frames])

+ classes = map(self.GetClassFromStackFrame,

+ crash_stack.frames[:top_n_frames])

# Since we're only going to return the highest-ranked class, might

# as well set ``max_classes`` to 1.

« no previous file with comments | « appengine/findit/crash/predator.py ('k') | appengine/findit/crash/stacktrace.py » ('j') | no next file with comments »