appengine/findit/crash/predator.py - Issue 2562623004: Making CallStack immutable, so it can be hashable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/crash/predator.py

Issue 2562623004: Making CallStack immutable, so it can be hashable (Closed)

Patch Set: Addressing nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/crash/predator.py

diff --git a/appengine/findit/crash/predator.py b/appengine/findit/crash/predator.py

index 9c61a89809cfe6fda0d06538753a1b6d9ffea359..9040ff302d842d9a07d8cfb28ae873b569e037ad 100644

--- a/appengine/findit/crash/predator.py

+++ b/appengine/findit/crash/predator.py

@@ -16,6 +16,7 @@ class Predator(object): # pragma: no cover

def FindCulprit(self, report):

"""Given a CrashReport, return a Culprit."""

suspected_cls = self.cl_classifier(report)

+ assert suspected_cls is not None

suspected_project = self.project_classifier.Classify(

suspected_cls, report.stacktrace.crash_stack)