Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2562623002: net: remove unused parameter from EpollEvent (Closed)

Created:
4 years ago by tfarina
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: remove unused parameter from EpollEvent We don't assign is_epoll_wait to anything in EpollEvent, and thus it is unused. So there is no reason to keep it there from now on. BUG=None TEST=net_unittests R=rch@chromium.org Committed: https://crrev.com/bcc003b080641e7f4e3856372908915e0ad7c34e Cr-Commit-Position: refs/heads/master@{#437527}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M net/tools/epoll_server/epoll_server.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/epoll_server/epoll_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tfarina
4 years ago (2016-12-08 03:07:33 UTC) #5
Ryan Hamilton
lgtm
4 years ago (2016-12-08 23:42:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562623002/1
4 years ago (2016-12-09 13:21:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 13:46:54 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-09 13:49:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcc003b080641e7f4e3856372908915e0ad7c34e
Cr-Commit-Position: refs/heads/master@{#437527}

Powered by Google App Engine
This is Rietveld 408576698