Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2562583003: Some resolution runtime errors are kernel malformedTypeErrors (Closed)

Created:
4 years ago by sra1
Modified:
4 years ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Some resolution runtime errors are kernel malformedTypeErrors We need to make sure both methods are available since we don't know which resolution errors will use which helper. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/a9b8d6ce2aa0484ad5f7c9476ae05fda5bd1d089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
4 years ago (2016-12-08 01:37:56 UTC) #2
Emily Fortuna
lgtm
4 years ago (2016-12-08 01:39:00 UTC) #3
sra1
4 years ago (2016-12-08 03:26:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a9b8d6ce2aa0484ad5f7c9476ae05fda5bd1d089 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698