Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1898)

Side by Side Diff: pkg/compiler/lib/src/js_backend/backend_impact.dart

Issue 2562583003: Some resolution runtime errors are kernel malformedTypeErrors (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.js_helpers.impact; 5 library dart2js.js_helpers.impact;
6 6
7 import '../common/names.dart'; 7 import '../common/names.dart';
8 import '../compiler.dart' show Compiler; 8 import '../compiler.dart' show Compiler;
9 import '../core_types.dart' show CommonElements; 9 import '../core_types.dart' show CommonElements;
10 import '../dart_types.dart' show InterfaceType; 10 import '../dart_types.dart' show InterfaceType;
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 helpers.jsMutableArrayClass, 229 helpers.jsMutableArrayClass,
230 helpers.jsFixedArrayClass, 230 helpers.jsFixedArrayClass,
231 helpers.jsExtendableArrayClass, 231 helpers.jsExtendableArrayClass,
232 helpers.jsUnmodifiableArrayClass 232 helpers.jsUnmodifiableArrayClass
233 ]); 233 ]);
234 } 234 }
235 235
236 BackendImpact _throwRuntimeError; 236 BackendImpact _throwRuntimeError;
237 237
238 BackendImpact get throwRuntimeError { 238 BackendImpact get throwRuntimeError {
239 return _throwRuntimeError ??= new BackendImpact(staticUses: [ 239 return _throwRuntimeError ??= new BackendImpact(
240 helpers.throwRuntimeError 240 staticUses: compiler.options.useKernel
241 ], otherImpacts: [ 241 ? [
242 // Also register the types of the arguments passed to this method. 242 // TODO(sra): Refactor impacts so that we know which of these
243 stringValues 243 // are called.
244 ]); 244 helpers.malformedTypeError,
245 helpers.throwRuntimeError,
246 ]
247 : [
248 helpers.throwRuntimeError,
249 ],
250 otherImpacts: [
251 // Also register the types of the arguments passed to this method.
252 stringValues
253 ]);
245 } 254 }
246 255
247 BackendImpact _superNoSuchMethod; 256 BackendImpact _superNoSuchMethod;
248 257
249 BackendImpact get superNoSuchMethod { 258 BackendImpact get superNoSuchMethod {
250 return _superNoSuchMethod ??= new BackendImpact(staticUses: [ 259 return _superNoSuchMethod ??= new BackendImpact(staticUses: [
251 helpers.createInvocationMirror, 260 helpers.createInvocationMirror,
252 helpers.objectNoSuchMethod 261 helpers.objectNoSuchMethod
253 ], otherImpacts: [ 262 ], otherImpacts: [
254 _needsInt('Needed to encode the invocation kind of super.noSuchMethod.'), 263 _needsInt('Needed to encode the invocation kind of super.noSuchMethod.'),
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
721 730
722 BackendImpact _staticClosure; 731 BackendImpact _staticClosure;
723 732
724 /// Backend impact for performing closurization of a top-level or static 733 /// Backend impact for performing closurization of a top-level or static
725 /// function. 734 /// function.
726 BackendImpact get staticClosure { 735 BackendImpact get staticClosure {
727 return _staticClosure ??= 736 return _staticClosure ??=
728 new BackendImpact(globalClasses: [helpers.closureClass]); 737 new BackendImpact(globalClasses: [helpers.closureClass]);
729 } 738 }
730 } 739 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698