Properly ref count IFX_FileAccess.

Properly ref count IFX_FileAccess.

Committed: https://pdfium.googlesource.com/pdfium/+/a9d29df6a774737a661d0f37f6b8aa5cba179c06

[Tom Sepez, 2016-12-07 22:14:48]

Description was changed from

==========
More RetainPtrs.
==========

to

==========
Properly ref count IFX_FileAccess.
==========

[Tom Sepez, 2016-12-07 22:23:28]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 22:23:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-07 22:25:53]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-12-07 22:25:54]

Dan, ready for review.

[commit-bot: I haz the power, 2016-12-07 22:36:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 22:36:33]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-12-07 23:05:03]

lgtm w/ nits

https://codereview.chromium.org/2562563002/diff/1/core/fxcrt/fx_extension.cpp
File core/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/2562563002/diff/1/core/fxcrt/fx_extension.cpp...
core/fxcrt/fx_extension.cpp:29: friend CFX_RetainPtr<T>
pdfium::MakeRetain(Args&&... args);
Does this need to be public?

https://codereview.chromium.org/2562563002/diff/1/xfa/fgas/font/cfgas_fontmgr...
File xfa/fgas/font/cfgas_fontmgr.cpp (right):

https://codereview.chromium.org/2562563002/diff/1/xfa/fgas/font/cfgas_fontmgr...
xfa/fgas/font/cfgas_fontmgr.cpp:570: FX_POSITION& pos) {
Can this be a * instead of an &?

[Tom Sepez, 2016-12-07 23:26:55]

https://codereview.chromium.org/2562563002/diff/1/core/fxcrt/fx_extension.cpp
File core/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/2562563002/diff/1/core/fxcrt/fx_extension.cpp...
core/fxcrt/fx_extension.cpp:29: friend CFX_RetainPtr<T>
pdfium::MakeRetain(Args&&... args);
On 2016/12/07 23:05:03, dsinclair wrote:
> Does this need to be public?

In C++, the placement of the friend statement doesn't matter with regards to
public/protected/private (I had too look it up, too) -- the friend gets all
access.

I placed this here to give the reader a hint that the only way to get
one of these is via MakeRetain, since this is where you'd look for a ctor
normallly.

https://codereview.chromium.org/2562563002/diff/1/xfa/fgas/font/cfgas_fontmgr...
File xfa/fgas/font/cfgas_fontmgr.cpp (right):

https://codereview.chromium.org/2562563002/diff/1/xfa/fgas/font/cfgas_fontmgr...
xfa/fgas/font/cfgas_fontmgr.cpp:570: FX_POSITION& pos) {
On 2016/12/07 23:05:03, dsinclair wrote:
> Can this be a * instead of an &?

It could, but this goes far beyond this  -- the FX iterator pattern uses
(FX_POSITION& pos) throughout the codebase.

[Tom Sepez, 2016-12-07 23:27:53]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-12-07 23:27:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 23:28:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481153273507880, "parent_rev":
"cd5e12a9ea397b48056643a7b65126395eec3174", "commit_rev":
"a9d29df6a774737a661d0f37f6b8aa5cba179c06"}

[commit-bot: I haz the power, 2016-12-07 23:28:18]

Description was changed from

==========
Properly ref count IFX_FileAccess.
==========

to

==========
Properly ref count IFX_FileAccess.

Committed:
https://pdfium.googlesource.com/pdfium/+/a9d29df6a774737a661d0f37f6b8aa5cba17...
==========

[commit-bot: I haz the power, 2016-12-07 23:28:18]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/a9d29df6a774737a661d0f37f6b8aa5cba17...