Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2231)

Unified Diff: core/fxcrt/fx_stream.h

Issue 2562563002: Properly ref count IFX_FileAccess. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fxcrt/fx_stream.h
diff --git a/core/fxcrt/fx_stream.h b/core/fxcrt/fx_stream.h
index b998761742cfb837832da3894a11d10603391453..2f4b5ad28055c5c5aa89ea94c7963f2c1f85e03c 100644
--- a/core/fxcrt/fx_stream.h
+++ b/core/fxcrt/fx_stream.h
@@ -143,13 +143,11 @@ class IFX_BufferedReadStream : public IFX_ReadStream {
};
#ifdef PDF_ENABLE_XFA
-class IFX_FileAccess {
+class IFX_FileAccess : public CFX_Retainable {
public:
- static IFX_FileAccess* CreateDefault(const CFX_WideStringC& wsPath);
+ static CFX_RetainPtr<IFX_FileAccess> CreateDefault(
+ const CFX_WideStringC& wsPath);
- virtual ~IFX_FileAccess() {}
- virtual void Release() = 0;
- virtual IFX_FileAccess* Retain() = 0;
virtual void GetPath(CFX_WideString& wsPath) = 0;
virtual CFX_RetainPtr<IFX_SeekableStream> CreateFileStream(
uint32_t dwModes) = 0;

Powered by Google App Engine
This is Rietveld 408576698