Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2354)

Unified Diff: ash/common/shelf/wm_shelf.cc

Issue 2562413003: Changes threshold frequency for investigation (based on video in the bug) (Closed)
Patch Set: Changes threshold frequency for investigation (based on video in the bug) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/wm_shelf.cc
diff --git a/ash/common/shelf/wm_shelf.cc b/ash/common/shelf/wm_shelf.cc
index e439381929be6836869bb732665d2bf36d8c5d57..c46e6c5cfa2848cb01eca47b8a3c0bbb07bff720 100644
--- a/ash/common/shelf/wm_shelf.cc
+++ b/ash/common/shelf/wm_shelf.cc
@@ -168,11 +168,11 @@ void WmShelf::SetAutoHideBehavior(ShelfAutoHideBehavior auto_hide_behavior) {
// Force a stack dump when this method is invoked too frequently.
// This block is here temporary to help investigate http://crbug.com/665093 .
- constexpr int kAutoHideRepeatInterval = 10000;
- constexpr int kMaxAutoHideChangesIn10Seconds = 100;
+ constexpr int kAutoHideRepeatInterval = 15000;
+ constexpr int kMaxAutoHideChanges = 15;
if ((base::TimeTicks::Now() - time_last_auto_hide_change_).InMilliseconds() <
kAutoHideRepeatInterval) {
varkha 2016/12/14 16:50:54 This actually feels wrong. My intention was to CHE
varkha 2016/12/19 21:48:50 Done.
- if (++count_auto_hide_changes_ > kMaxAutoHideChangesIn10Seconds)
+ if (++count_auto_hide_changes_ > kMaxAutoHideChanges)
CHECK(false);
} else {
count_auto_hide_changes_ = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698