Changes threshold frequency for investigation (based on video in the bug)

ash/common/shelf/wm_shelf.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/shelf/wm_shelf.h"
 
 #include "ash/common/shelf/shelf_controller.h"
 #include "ash/common/shelf/shelf_delegate.h"
 #include "ash/common/shelf/shelf_item_delegate.h"
 #include "ash/common/shelf/shelf_layout_manager.h"
@@ skipping 150 matching lines @@
 
 int WmShelf::PrimaryAxisValue(int horizontal, int vertical) const {
   return IsHorizontalAlignment() ? horizontal : vertical;
 }
 
 void WmShelf::SetAutoHideBehavior(ShelfAutoHideBehavior auto_hide_behavior) {
   DCHECK(shelf_layout_manager_);
 
   // Force a stack dump when this method is invoked too frequently.
   // This block is here temporary to help investigate http://crbug.com/665093 .
-  constexpr int kAutoHideRepeatInterval = 10000;
-  constexpr int kMaxAutoHideChangesIn10Seconds = 100;
+  constexpr int kAutoHideRepeatInterval = 15000;
+  constexpr int kMaxAutoHideChanges = 15;
   if ((base::TimeTicks::Now() - time_last_auto_hide_change_).InMilliseconds() <
       kAutoHideRepeatInterval) {

[varkha, 2016/12/14 16:50:54]

This actually feels wrong. My intention was to CHECK when number of events in
interval is > threshold. Both current and suggested code is doing something very
different so both are prone to being triggered manually. I will need to rework
this and also make the test that repeatedly swipes up and down on the shelf take
this into account.

[varkha, 2016/12/19 21:48:50]

Done.

-    if (++count_auto_hide_changes_ > kMaxAutoHideChangesIn10Seconds)
+    if (++count_auto_hide_changes_ > kMaxAutoHideChanges)
       CHECK(false);
   } else {
     count_auto_hide_changes_ = 0;
   }
   time_last_auto_hide_change_ = base::TimeTicks::Now();
 
   if (auto_hide_behavior_ == auto_hide_behavior)
     return;
 
   auto_hide_behavior_ = auto_hide_behavior;
@@ skipping 153 matching lines @@
 
 void WmShelf::OnBackgroundUpdated(ShelfBackgroundType background_type,
                                   BackgroundAnimatorChangeType change_type) {
   if (background_type == GetBackgroundType())
     return;
   for (auto& observer : observers_)
     observer.OnBackgroundTypeChanged(background_type, change_type);
 }
 
 }  // namespace ash