Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2562403003: Fix include guards of files in src/ios. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, pkl (ping after 24h if needed), extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix include guards of files in src/ios. Some files include guards had not been fixed when the files were upstreamed. Fix that. BUG=None Committed: https://crrev.com/03adaf9335458eb01355c1c37ef07a351e460d4b Cr-Commit-Position: refs/heads/master@{#437915}

Patch Set 1 #

Patch Set 2 : Really fix include guards. #

Patch Set 3 : Fix many more header guards. #

Patch Set 4 : Rebase on origin/master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -90 lines) Patch
M ios/chrome/app/application_delegate/memory_warning_helper.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/browser_state_metrics/browser_state_metrics.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browsing_data/browsing_data_counter_wrapper.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/geolocation/CLLocation+OmniboxGeolocation.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/infobars/confirm_infobar_controller+protected.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/share_extension/share_extension_item_receiver.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/share_extension/share_extension_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/signin/fake_signin_manager_builder.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/UIView+SizeClassSupport.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/rtl_geometry.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/webui/crashes_ui.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/web/web_controller_provider_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/crnet/CrNet.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M ios/crnet/crnet_consumer/crnet_consumer_app_delegate.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/crnet/crnet_consumer/crnet_consumer_view_controller.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/public/provider/chrome/browser/geolocation_updater_provider.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/public/provider/chrome/browser/spotlight/spotlight_provider.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/public/provider/chrome/browser/spotlight/test_spotlight_provider.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/public/provider/chrome/browser/voice/voice_search_controller.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/public/crw_browsing_data_store.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/public/crw_browsing_data_store_delegate.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/public/favicon_url.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/public/load_committed_details.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/public/test/mock_image_data_fetcher.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/public/test/response_providers/string_response_provider.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/public/test/test_web_client.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/public/test/web_js_test.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/public/test/web_view_interaction_test_util.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M ios/web/test/web_int_test.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/url_data_manager_ios_backend.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/webui/url_data_source_ios_impl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years ago (2016-12-12 15:39:21 UTC) #3
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-12 15:45:28 UTC) #7
sdefresne
I've found and fixed many more errors, can you take another look?
4 years ago (2016-12-12 16:01:32 UTC) #10
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-12 17:58:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562403003/60001
4 years ago (2016-12-12 19:45:11 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-12 21:27:42 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-12 21:29:43 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/03adaf9335458eb01355c1c37ef07a351e460d4b
Cr-Commit-Position: refs/heads/master@{#437915}

Powered by Google App Engine
This is Rietveld 408576698