MD WebUI: Simplify cr-toolbar CSS

MD WebUI: Simplify cr-toolbar CSS

This removes a number of CSS mixins which allowed almost all parts of
the toolbar to be changed. Instead, this adds better support to the
toolbar for having an action button on the right side of the element,
and migrates History and Downloads to use it.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/abaa208feeda5799c50d802f2ebc5e8b81aa00b2
Cr-Commit-Position: refs/heads/master@{#439710}

[tsergeant, 2016-12-13 03:49:42]

Description was changed from

==========
MD WebUI: Simplify cr-toolbar CSS

This removes a number of CSS mixins which allowed almost all parts of
the toolbar to be changed. Instead, this adds better support to the
toolbar for having an action button on the right side of the element,
and migrates History and Downloads to use it.

BUG=665700
==========

to

==========
MD WebUI: Simplify cr-toolbar CSS

This removes a number of CSS mixins which allowed almost all parts of
the toolbar to be changed. Instead, this adds better support to the
toolbar for having an action button on the right side of the element,
and migrates History and Downloads to use it.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-12-13 04:10:49]

tsergeant@chromium.org changed reviewers:
+ dbeam@chromium.org

[tsergeant, 2016-12-13 04:10:49]

Please take a look!

Screenshots: https://imgur.com/a/F8I8B

I've done my best to verify that there are no visual changes. The only thing I
can see is that the menu icon in Downloads shifts 2px left, which matches
History (and the mocks).

[Dan Beam, 2016-12-13 07:09:01]

lgtm but did you try ... around 900px in Russian?

https://codereview.chromium.org/2562393003/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html (right):

https://codereview.chromium.org/2562393003/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html:72:
-webkit-padding-end: var(--cr-toolbar-field-end-padding, 12px);
who sets --cr-toolbar-field-end-padding now?

[tsergeant, 2016-12-13 23:53:47]

https://codereview.chromium.org/2562393003/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html (right):

https://codereview.chromium.org/2562393003/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html:72:
-webkit-padding-end: var(--cr-toolbar-field-end-padding, 12px);
On 2016/12/13 07:09:01, Dan Beam wrote:
> who sets --cr-toolbar-field-end-padding now?

No-one, so I've removed it.

[tsergeant, 2016-12-14 06:38:55]

Patchset #4 (id:60001) has been deleted

[tsergeant, 2016-12-14 06:46:08]

As we discussed, there are 3 main options for dealing with the long text in
other languages:

1. Ellipsize (current strategy in Patch set 3)
2. Push the search bar to the right
3. Change the breakpoints

I've uploaded a patch which pushes the search bar, in the style of the Downloads
page. It generally simplifies things, with a couple of gnarly bits to do with
padding.

What do you think?

[tsergeant, 2016-12-20 01:40:30]

On 2016/12/14 06:46:08, tsergeant wrote:
> As we discussed, there are 3 main options for dealing with the long text in
> other languages:
> 
> 1. Ellipsize (current strategy in Patch set 3)
> 2. Push the search bar to the right
> 3. Change the breakpoints
> 
> I've uploaded a patch which pushes the search bar, in the style of the
Downloads
> page. It generally simplifies things, with a couple of gnarly bits to do with
> padding.
> 
> What do you think?

Ping dbeam. What do you think about the approach taken in patchset 4?

[Dan Beam, 2016-12-20 02:23:21]

lgtm (just tried locally, pushing is fine for these rare cases I suppose)

[tsergeant, 2016-12-20 03:51:27]

Thanks for reviewing!

[tsergeant, 2016-12-20 03:51:30]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-12-20 03:51:30]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2562393003/#ps100001
(title: "Fix padding, add explanatory comment, revulcanize")

[commit-bot: I haz the power, 2016-12-20 03:51:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 04:54:03]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482205890233500,
"parent_rev": "0c5bdb8d136a4cf0a0a6388c6db2f33f7ce1e078", "commit_rev":
"a2ba9b4185de3a1b7f0c1d9488500a1e8e472536"}

[commit-bot: I haz the power, 2016-12-20 04:54:33]

Description was changed from

==========
MD WebUI: Simplify cr-toolbar CSS

This removes a number of CSS mixins which allowed almost all parts of
the toolbar to be changed. Instead, this adds better support to the
toolbar for having an action button on the right side of the element,
and migrates History and Downloads to use it.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Simplify cr-toolbar CSS

This removes a number of CSS mixins which allowed almost all parts of
the toolbar to be changed. Instead, this adds better support to the
toolbar for having an action button on the right side of the element,
and migrates History and Downloads to use it.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2562393003
==========

[commit-bot: I haz the power, 2016-12-20 04:54:34]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-12-20 04:57:57]

Description was changed from

==========
MD WebUI: Simplify cr-toolbar CSS

This removes a number of CSS mixins which allowed almost all parts of
the toolbar to be changed. Instead, this adds better support to the
toolbar for having an action button on the right side of the element,
and migrates History and Downloads to use it.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2562393003
==========

to

==========
MD WebUI: Simplify cr-toolbar CSS

This removes a number of CSS mixins which allowed almost all parts of
the toolbar to be changed. Instead, this adds better support to the
toolbar for having an action button on the right side of the element,
and migrates History and Downloads to use it.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/abaa208feeda5799c50d802f2ebc5e8b81aa00b2
Cr-Commit-Position: refs/heads/master@{#439710}
==========

[commit-bot: I haz the power, 2016-12-20 04:57:58]

Patchset 5 (id:??) landed as
https://crrev.com/abaa208feeda5799c50d802f2ebc5e8b81aa00b2
Cr-Commit-Position: refs/heads/master@{#439710}