Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2562383002: [heap] Black areas are created for both linear and free list allocations. (Closed)

Created:
4 years ago by Hannes Payer (out of office)
Modified:
4 years ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Black areas are created for both linear and free list allocations. BUG= Committed: https://crrev.com/fc2503d137b4f72009a74a9c1eeb6656833d3962 Cr-Commit-Position: refs/heads/master@{#41646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M src/heap/spaces.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +13 lines, -8 lines 0 comments Download
M src/heap/spaces-inl.h View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Hannes Payer (out of office)
I decided to keep the current structure. PTAL.
4 years ago (2016-12-12 13:18:27 UTC) #2
ulan
lgtm
4 years ago (2016-12-12 13:38:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562383002/1
4 years ago (2016-12-12 13:45:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 14:45:44 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-12 14:46:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc2503d137b4f72009a74a9c1eeb6656833d3962
Cr-Commit-Position: refs/heads/master@{#41646}

Powered by Google App Engine
This is Rietveld 408576698