Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2562353002: [Android WebView] Add Internet permission. (Closed)

Created:
4 years ago by gsennton
Modified:
4 years ago
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Add Internet permission. Add the android.permission.INTERNET permission to the standalone WebView's apk, to allow Services belonging to WebView's package to connect to the internet. BUG=673280 Committed: https://crrev.com/a0d0931b1be19f440cfde28458d93d0c1ac504f5 Cr-Commit-Position: refs/heads/master@{#437851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M android_webview/apk/java/AndroidManifest.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
gsennton
Toby, ptal :) Adding Selim and Torne here just as an FYI since adding permissions ...
4 years ago (2016-12-12 11:35:35 UTC) #2
Tobias Sargeant
On 2016/12/12 11:35:35, gsennton wrote: > Toby, ptal :) > > Adding Selim and Torne ...
4 years ago (2016-12-12 11:59:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562353002/1
4 years ago (2016-12-12 12:01:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 12:21:10 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-12 15:11:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0d0931b1be19f440cfde28458d93d0c1ac504f5
Cr-Commit-Position: refs/heads/master@{#437851}

Powered by Google App Engine
This is Rietveld 408576698