Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 2562343002: Made Text#assignedSlot and Element#assignedSlot nullable. (Closed)

Created:
4 years ago by lunalu1
Modified:
4 years ago
Reviewers:
foolip
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made Text#assignedSlot and Element#assignedSlot nullable. Also changed the order of the attributes/methods under Shadow DOM to match the spec. BUG=662005 Committed: https://crrev.com/c4308a50c6dd3324293fb419a2762e9ae4c5e84b Cr-Commit-Position: refs/heads/master@{#437873}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Codereview update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M third_party/WebKit/Source/core/dom/Element.idl View 1 4 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.idl View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
foolip
lgtm % nits https://codereview.chromium.org/2562343002/diff/1/third_party/WebKit/Source/core/dom/Text.idl File third_party/WebKit/Source/core/dom/Text.idl (right): https://codereview.chromium.org/2562343002/diff/1/third_party/WebKit/Source/core/dom/Text.idl#newcode33 third_party/WebKit/Source/core/dom/Text.idl:33: NodeList getDestinationInsertionPoints(); Add back Shadow DOM ...
4 years ago (2016-12-12 11:33:48 UTC) #8
foolip
lgtm
4 years ago (2016-12-12 11:38:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562343002/20001
4 years ago (2016-12-12 11:38:41 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/197057)
4 years ago (2016-12-12 13:12:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562343002/20001
4 years ago (2016-12-12 13:24:35 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-12 15:05:15 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-12 15:12:20 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4308a50c6dd3324293fb419a2762e9ae4c5e84b
Cr-Commit-Position: refs/heads/master@{#437873}

Powered by Google App Engine
This is Rietveld 408576698