|
|
Chromium Code Reviews
DescriptionMade Text#assignedSlot and Element#assignedSlot nullable.
Also changed the order of the attributes/methods under Shadow DOM to match the spec.
BUG=662005
Committed: https://crrev.com/c4308a50c6dd3324293fb419a2762e9ae4c5e84b
Cr-Commit-Position: refs/heads/master@{#437873}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Codereview update #
Messages
Total messages: 26 (19 generated)
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Made Text#assignedSlot and Element#assignedSlot nullable. Changed the order of the attributes/methods under Shadow DOM to match the spec. BUG=662005 ========== to ========== Made Text#assignedSlot and Element#assignedSlot nullable. Changed the order of the attributes/methods under Shadow DOM to match the spec. BUG=662005 ==========
Description was changed from ========== Made Text#assignedSlot and Element#assignedSlot nullable. Changed the order of the attributes/methods under Shadow DOM to match the spec. BUG=662005 ========== to ========== Made Text#assignedSlot and Element#assignedSlot nullable. Changed the order of the attributes/methods under Shadow DOM to match the spec. BUG=662005 ==========
Description was changed from ========== Made Text#assignedSlot and Element#assignedSlot nullable. Changed the order of the attributes/methods under Shadow DOM to match the spec. BUG=662005 ========== to ========== Made Text#assignedSlot and Element#assignedSlot nullable. Also changed the order of the attributes/methods under Shadow DOM to match the spec. BUG=662005 ==========
Description was changed from ========== Made Text#assignedSlot and Element#assignedSlot nullable. Also changed the order of the attributes/methods under Shadow DOM to match the spec. BUG=662005 ========== to ========== Made Text#assignedSlot and Element#assignedSlot nullable. Also changed the order of the attributes/methods under Shadow DOM to match the spec. BUG=662005 ==========
foolip@chromium.org changed reviewers: + foolip@chromium.org
lgtm % nits https://codereview.chromium.org/2562343002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/Text.idl (right): https://codereview.chromium.org/2562343002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/Text.idl:33: NodeList getDestinationInsertionPoints(); Add back Shadow DOM + link
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
lgtm
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by foolip@chromium.org
The CQ bit was checked by foolip@chromium.org
The CQ bit was checked by lunalu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by lunalu@chromium.org
The CQ bit was checked by lunalu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481549068627220,
"parent_rev": "7dac9d5093426afe74055db803a63ec392ca19fa", "commit_rev":
"a2f95d0397d4fc6c701b934bda388277936c8345"}
Message was sent while issue was closed.
Description was changed from ========== Made Text#assignedSlot and Element#assignedSlot nullable. Also changed the order of the attributes/methods under Shadow DOM to match the spec. BUG=662005 ========== to ========== Made Text#assignedSlot and Element#assignedSlot nullable. Also changed the order of the attributes/methods under Shadow DOM to match the spec. BUG=662005 Review-Url: https://codereview.chromium.org/2562343002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Made Text#assignedSlot and Element#assignedSlot nullable. Also changed the order of the attributes/methods under Shadow DOM to match the spec. BUG=662005 Review-Url: https://codereview.chromium.org/2562343002 ========== to ========== Made Text#assignedSlot and Element#assignedSlot nullable. Also changed the order of the attributes/methods under Shadow DOM to match the spec. BUG=662005 Committed: https://crrev.com/c4308a50c6dd3324293fb419a2762e9ae4c5e84b Cr-Commit-Position: refs/heads/master@{#437873} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c4308a50c6dd3324293fb419a2762e9ae4c5e84b Cr-Commit-Position: refs/heads/master@{#437873}
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
