Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2562333002: [wasm] Handle potentially null callee-pc (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
Michael Starzinger
CC:
bradnelson, titzer, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Handle potentially null callee-pc This only happens if there is a asm.js-wasm-frame on top of the stack trace, which was not covered by our tests so far. The regression test create a stack overflow in asm.js code, triggering this case. R=mstarzinger@chromium.org CC=titzer@chromium.org, bradnelson@chromium.org BUG=chromium:673241 Committed: https://crrev.com/c69b48adc4cd4c36c44eac8efcac51bdbb1fdc5c Cr-Commit-Position: refs/heads/master@{#41639}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix test case #

Patch Set 3 : Even nicer test case #

Patch Set 4 : Remove check for RangeError, becuase of unrelated bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M src/frames.h View 1 chunk +3 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-673241.js View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
Clemens Hammacher
4 years ago (2016-12-12 09:39:32 UTC) #3
Michael Starzinger
LGTM. https://codereview.chromium.org/2562333002/diff/1/test/mjsunit/regress/regress-673241.js File test/mjsunit/regress/regress-673241.js (right): https://codereview.chromium.org/2562333002/diff/1/test/mjsunit/regress/regress-673241.js#newcode13 test/mjsunit/regress/regress-673241.js:13: generateAsmJs()(); nit: Shouldn't this say "assertThrows(generateAsmJs(), RangeError)" here?
4 years ago (2016-12-12 09:53:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562333002/60001
4 years ago (2016-12-12 12:04:36 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-12 12:29:55 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-12 12:30:48 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c69b48adc4cd4c36c44eac8efcac51bdbb1fdc5c
Cr-Commit-Position: refs/heads/master@{#41639}

Powered by Google App Engine
This is Rietveld 408576698