Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2562323002: Devirtualize Frame::domWindow(). (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrame.h
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.h b/third_party/WebKit/Source/core/frame/LocalFrame.h
index c979b7b23e4bf5c673751fa8c342675890995f3b..fb15870385883cdc2dd4670bbb7544fa8596c0bd 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.h
@@ -106,7 +106,6 @@ class CORE_EXPORT LocalFrame final : public Frame,
// Frame overrides:
~LocalFrame() override;
DECLARE_VIRTUAL_TRACE();
- DOMWindow* domWindow() const override;
WindowProxy* windowProxy(DOMWrapperWorld&) override;
void navigate(Document& originDocument,
const KURL&,
@@ -125,7 +124,7 @@ class CORE_EXPORT LocalFrame final : public Frame,
void detachChildren();
void documentAttached();
- LocalDOMWindow* localDOMWindow() const;
+ LocalDOMWindow* domWindow() const;
void setDOMWindow(LocalDOMWindow*);
FrameView* view() const;
Document* document() const;
@@ -249,7 +248,6 @@ class CORE_EXPORT LocalFrame final : public Frame,
Member<NavigationScheduler> m_navigationScheduler;
Member<FrameView> m_view;
- Member<LocalDOMWindow> m_domWindow;
// Usually 0. Non-null if this is the top frame of PagePopup.
Member<Element> m_pagePopupOwner;
@@ -279,10 +277,6 @@ inline void LocalFrame::init() {
m_loader.init();
}
-inline LocalDOMWindow* LocalFrame::localDOMWindow() const {
- return m_domWindow.get();
-}
-
inline FrameLoader& LocalFrame::loader() const {
return m_loader;
}

Powered by Google App Engine
This is Rietveld 408576698