Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 2562323002: Devirtualize Frame::domWindow(). (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
9 * reserved. 9 * reserved.
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 const Color&, 99 const Color&,
100 bool, 100 bool,
101 ScrollbarMode = ScrollbarAuto, 101 ScrollbarMode = ScrollbarAuto,
102 bool horizontalLock = false, 102 bool horizontalLock = false,
103 ScrollbarMode = ScrollbarAuto, 103 ScrollbarMode = ScrollbarAuto,
104 bool verticalLock = false); 104 bool verticalLock = false);
105 105
106 // Frame overrides: 106 // Frame overrides:
107 ~LocalFrame() override; 107 ~LocalFrame() override;
108 DECLARE_VIRTUAL_TRACE(); 108 DECLARE_VIRTUAL_TRACE();
109 DOMWindow* domWindow() const override;
110 WindowProxy* windowProxy(DOMWrapperWorld&) override; 109 WindowProxy* windowProxy(DOMWrapperWorld&) override;
111 void navigate(Document& originDocument, 110 void navigate(Document& originDocument,
112 const KURL&, 111 const KURL&,
113 bool replaceCurrentItem, 112 bool replaceCurrentItem,
114 UserGestureStatus) override; 113 UserGestureStatus) override;
115 void navigate(const FrameLoadRequest&) override; 114 void navigate(const FrameLoadRequest&) override;
116 void reload(FrameLoadType, ClientRedirectPolicy) override; 115 void reload(FrameLoadType, ClientRedirectPolicy) override;
117 void detach(FrameDetachType) override; 116 void detach(FrameDetachType) override;
118 bool shouldClose() override; 117 bool shouldClose() override;
119 SecurityContext* securityContext() const override; 118 SecurityContext* securityContext() const override;
120 void printNavigationErrorMessage(const Frame&, const char* reason) override; 119 void printNavigationErrorMessage(const Frame&, const char* reason) override;
121 bool prepareForCommit() override; 120 bool prepareForCommit() override;
122 void didChangeVisibilityState() override; 121 void didChangeVisibilityState() override;
123 void setDocumentHasReceivedUserGesture() override; 122 void setDocumentHasReceivedUserGesture() override;
124 123
125 void detachChildren(); 124 void detachChildren();
126 void documentAttached(); 125 void documentAttached();
127 126
128 LocalDOMWindow* localDOMWindow() const; 127 LocalDOMWindow* domWindow() const;
129 void setDOMWindow(LocalDOMWindow*); 128 void setDOMWindow(LocalDOMWindow*);
130 FrameView* view() const; 129 FrameView* view() const;
131 Document* document() const; 130 Document* document() const;
132 void setPagePopupOwner(Element&); 131 void setPagePopupOwner(Element&);
133 Element* pagePopupOwner() const { return m_pagePopupOwner.get(); } 132 Element* pagePopupOwner() const { return m_pagePopupOwner.get(); }
134 133
135 // Root of the layout tree for the document contained in this frame. 134 // Root of the layout tree for the document contained in this frame.
136 LayoutView* contentLayoutObject() const; 135 LayoutView* contentLayoutObject() const;
137 LayoutViewItem contentLayoutItem() const; 136 LayoutViewItem contentLayoutItem() const;
138 137
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 241
243 void enableNavigation() { --m_navigationDisableCount; } 242 void enableNavigation() { --m_navigationDisableCount; }
244 void disableNavigation() { ++m_navigationDisableCount; } 243 void disableNavigation() { ++m_navigationDisableCount; }
245 244
246 std::unique_ptr<WebFrameScheduler> m_frameScheduler; 245 std::unique_ptr<WebFrameScheduler> m_frameScheduler;
247 246
248 mutable FrameLoader m_loader; 247 mutable FrameLoader m_loader;
249 Member<NavigationScheduler> m_navigationScheduler; 248 Member<NavigationScheduler> m_navigationScheduler;
250 249
251 Member<FrameView> m_view; 250 Member<FrameView> m_view;
252 Member<LocalDOMWindow> m_domWindow;
253 // Usually 0. Non-null if this is the top frame of PagePopup. 251 // Usually 0. Non-null if this is the top frame of PagePopup.
254 Member<Element> m_pagePopupOwner; 252 Member<Element> m_pagePopupOwner;
255 253
256 const Member<ScriptController> m_script; 254 const Member<ScriptController> m_script;
257 const Member<Editor> m_editor; 255 const Member<Editor> m_editor;
258 const Member<SpellChecker> m_spellChecker; 256 const Member<SpellChecker> m_spellChecker;
259 const Member<FrameSelection> m_selection; 257 const Member<FrameSelection> m_selection;
260 const Member<EventHandler> m_eventHandler; 258 const Member<EventHandler> m_eventHandler;
261 const Member<FrameConsole> m_console; 259 const Member<FrameConsole> m_console;
262 const Member<InputMethodController> m_inputMethodController; 260 const Member<InputMethodController> m_inputMethodController;
263 261
264 int m_navigationDisableCount; 262 int m_navigationDisableCount;
265 263
266 float m_pageZoomFactor; 264 float m_pageZoomFactor;
267 float m_textZoomFactor; 265 float m_textZoomFactor;
268 266
269 bool m_inViewSourceMode; 267 bool m_inViewSourceMode;
270 268
271 Member<InstrumentingAgents> m_instrumentingAgents; 269 Member<InstrumentingAgents> m_instrumentingAgents;
272 Member<PerformanceMonitor> m_performanceMonitor; 270 Member<PerformanceMonitor> m_performanceMonitor;
273 271
274 InterfaceProvider* const m_interfaceProvider; 272 InterfaceProvider* const m_interfaceProvider;
275 InterfaceRegistry* const m_interfaceRegistry; 273 InterfaceRegistry* const m_interfaceRegistry;
276 }; 274 };
277 275
278 inline void LocalFrame::init() { 276 inline void LocalFrame::init() {
279 m_loader.init(); 277 m_loader.init();
280 } 278 }
281 279
282 inline LocalDOMWindow* LocalFrame::localDOMWindow() const {
283 return m_domWindow.get();
284 }
285
286 inline FrameLoader& LocalFrame::loader() const { 280 inline FrameLoader& LocalFrame::loader() const {
287 return m_loader; 281 return m_loader;
288 } 282 }
289 283
290 inline NavigationScheduler& LocalFrame::navigationScheduler() const { 284 inline NavigationScheduler& LocalFrame::navigationScheduler() const {
291 ASSERT(m_navigationScheduler); 285 ASSERT(m_navigationScheduler);
292 return *m_navigationScheduler.get(); 286 return *m_navigationScheduler.get();
293 } 287 }
294 288
295 inline FrameView* LocalFrame::view() const { 289 inline FrameView* LocalFrame::view() const {
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 explicit ScopedFrameBlamer(LocalFrame*); 369 explicit ScopedFrameBlamer(LocalFrame*);
376 ~ScopedFrameBlamer(); 370 ~ScopedFrameBlamer();
377 371
378 private: 372 private:
379 Member<LocalFrame> m_frame; 373 Member<LocalFrame> m_frame;
380 }; 374 };
381 375
382 } // namespace blink 376 } // namespace blink
383 377
384 #endif // LocalFrame_h 378 #endif // LocalFrame_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698