Add ContextLifecycleObserver::frame()

Add ContextLifecycleObserver::frame()

I'm replacing DOMWindowProperty with ContextLifecycleObserver.
(ContextLifecycleObserver::contextDestroyed() is called already almost at the same
timing as DOMWindowProperty::frameDestroyed().)

To make the replacement easier, this CL introduces ContextLifecycleObserver::frame().
Also this CL moves ApplicationCache to ContextLifecycleObserver.

BUG=610176
Committed: https://crrev.com/164ea1ce58813039385db255a4fcd47f3a4b5205
Cr-Commit-Position: refs/heads/master@{#437852}

[haraken, 2016-12-12 06:26:29]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2016-12-12 06:26:29]

PTAL

[haraken, 2016-12-12 06:29:11]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 06:29:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2016-12-12 06:35:26]

lgtm

https://codereview.chromium.org/2562303002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h (right):

https://codereview.chromium.org/2562303002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h:42: LocalFrame*
frame() const;
Add a short comment stating when you can expect this to be non-null?

[haraken, 2016-12-12 06:40:49]

>
https://codereview.chromium.org/2562303002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h (right):
> 
>
https://codereview.chromium.org/2562303002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h:42: LocalFrame*
> frame() const;
> Add a short comment stating when you can expect this to be non-null?

Done.

[haraken, 2016-12-12 06:40:52]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-12-12 06:40:53]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2562303002/#ps20001
(title: "temp")

[commit-bot: I haz the power, 2016-12-12 06:41:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 08:27:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 08:27:49]

Failed to apply patch for
third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h:33
  error: third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h: patch
does not apply

Patch:       third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h
Index: third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h
diff --git a/third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h
b/third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h
index
4c35bddedf734f8ea29519cfb5fdff690ee487ac..4d6807dddad8a9d13b832b7883d7c2ee398f2c18
100644
--- a/third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h
+++ b/third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h
@@ -33,11 +33,18 @@
 
 namespace blink {
 
+class LocalFrame;
+
 class CORE_EXPORT ContextLifecycleObserver
     : public LifecycleObserver<ExecutionContext, ContextLifecycleObserver> {
  public:
+  // Returns null after the observing context is detached.
   ExecutionContext* getExecutionContext() const { return lifecycleContext(); }
 
+  // Returns null after the observing context is detached or if the context
+  // doesn't have a frame (i.e., if the context is not a Document).
+  LocalFrame* frame() const;
+
   enum Type {
     GenericType,
     ActiveDOMObjectType,

[haraken, 2016-12-12 08:41:57]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-12-12 08:41:57]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2562303002/#ps40001
(title: "temp")

[commit-bot: I haz the power, 2016-12-12 08:42:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 10:45:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 10:45:07]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[haraken, 2016-12-12 10:50:24]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-12 10:50:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 12:39:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481539824965980,
"parent_rev": "2b7a7d36450f1f48c3c2e00d41f5499e98c9cbac", "commit_rev":
"26486538af80a09ca5882cf65006b3a60b240d8d"}

[commit-bot: I haz the power, 2016-12-12 12:39:25]

Description was changed from

==========
Add ContextLifecycleObserver::frame()

I'm replacing DOMWindowProperty with ContextLifecycleObserver.
(ContextLifecycleObserver::contextDestroyed() is called already almost at the
same
timing as DOMWindowProperty::frameDestroyed().)

To make the replacement easier, this CL introduces
ContextLifecycleObserver::frame().
Also this CL moves ApplicationCache to ContextLifecycleObserver.

BUG=610176
==========

to

==========
Add ContextLifecycleObserver::frame()

I'm replacing DOMWindowProperty with ContextLifecycleObserver.
(ContextLifecycleObserver::contextDestroyed() is called already almost at the
same
timing as DOMWindowProperty::frameDestroyed().)

To make the replacement easier, this CL introduces
ContextLifecycleObserver::frame().
Also this CL moves ApplicationCache to ContextLifecycleObserver.

BUG=610176

Review-Url: https://codereview.chromium.org/2562303002
==========

[commit-bot: I haz the power, 2016-12-12 12:39:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-12 15:11:38]

Description was changed from

==========
Add ContextLifecycleObserver::frame()

I'm replacing DOMWindowProperty with ContextLifecycleObserver.
(ContextLifecycleObserver::contextDestroyed() is called already almost at the
same
timing as DOMWindowProperty::frameDestroyed().)

To make the replacement easier, this CL introduces
ContextLifecycleObserver::frame().
Also this CL moves ApplicationCache to ContextLifecycleObserver.

BUG=610176

Review-Url: https://codereview.chromium.org/2562303002
==========

to

==========
Add ContextLifecycleObserver::frame()

I'm replacing DOMWindowProperty with ContextLifecycleObserver.
(ContextLifecycleObserver::contextDestroyed() is called already almost at the
same
timing as DOMWindowProperty::frameDestroyed().)

To make the replacement easier, this CL introduces
ContextLifecycleObserver::frame().
Also this CL moves ApplicationCache to ContextLifecycleObserver.

BUG=610176

Committed: https://crrev.com/164ea1ce58813039385db255a4fcd47f3a4b5205
Cr-Commit-Position: refs/heads/master@{#437852}
==========

[commit-bot: I haz the power, 2016-12-12 15:11:39]

Patchset 3 (id:??) landed as
https://crrev.com/164ea1ce58813039385db255a4fcd47f3a4b5205
Cr-Commit-Position: refs/heads/master@{#437852}