Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2562273004: Revert of [heap] Initialize the owner on each page after lospace allocation (Closed)

Created:
4 years ago by Michael Hablich
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Initialize the owner on each page after lospace allocation (patchset #2 id:20001 of https://codereview.chromium.org/2565713002/ ) Reason for revert: Tree closer: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/12409 Original issue's description: > [heap] Initialize the owner on each page after lospace allocation > > The least two bits of the owner field of a Page are used to determine > whether the Page is part of a large object. If these bits are not equal > to 0x11, the page is part of a large object and needs special handling > e.g. in MemoryChunk::FromAnyPointerAddress to determine which chunk it > belongs to. > > This CL fixes an issue in which the store buffer overflows after > a large object space allocation but before the object has been fully > initialized. Store buffer overflow handling attempts to look up the > chunk of a page, but fails to do so correctly since the page's owner > field has not yet been initialized. > > This CL ensures that the owner field of all pages belonging to a large > object allocation are initialized to a value that is interpreted > correctly. > > BUG=chromium:672041 > > Committed: https://crrev.com/9b6808bfb5366beebe3af30a06f9851edb2039d4 > Cr-Commit-Position: refs/heads/master@{#41641} TBR=mlippautz@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:672041 Committed: https://crrev.com/1e70454f732a959a124b4de4522d9e2e5de56066 Cr-Commit-Position: refs/heads/master@{#41644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -36 lines) Patch
M src/heap/spaces.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +0 lines, -8 lines 0 comments Download
D test/mjsunit/regress/regress-672041.js View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Hablich
Created Revert of [heap] Initialize the owner on each page after lospace allocation
4 years ago (2016-12-12 14:36:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562273004/1
4 years ago (2016-12-12 14:36:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 14:36:41 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-12 14:37:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e70454f732a959a124b4de4522d9e2e5de56066
Cr-Commit-Position: refs/heads/master@{#41644}

Powered by Google App Engine
This is Rietveld 408576698