Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2562233002:
Fix IsFullScreenMode signature in chrome's fullscreen_ozone.cc (Closed)
|
Created:
4 years ago by Julien Isorce Samsung Modified:
4 years ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix IsFullScreenMode signature in chrome's fullscreen_ozone.cc
Chrome build fails when use_ozone is true.
R=sky@chromium.org, warx@chromium.org
BUG=496681
Committed: https://crrev.com/f468b1ac19374d7e5940e4322648598435265a7e
Cr-Commit-Position: refs/heads/master@{#438096}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/12/11 23:05:06, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. lgtm, sorry for this miss.
The CQ bit was checked by j.isorce@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/12 22:09:51, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: chrome/browser/fullscreen_ozone.cc Hi @sky, PTAL, Thx!
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
LGTM
The CQ bit was checked by j.isorce@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481616368976160, "parent_rev":
"db535f6d3499614d1c7c5d2c65c53231baa1e51e", "commit_rev":
"b694237017f0435fc019bf75876f24c9d92379be"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481616368976160, "parent_rev":
"91c2b63a69e93b01812deeaa627d31929a1b8ee0", "commit_rev":
"bfd96192855fb0852464c468142f2687ff3ed236"}
Message was sent while issue was closed.
Description was changed from ========== Fix IsFullScreenMode signature in chrome's fullscreen_ozone.cc Chrome build fails when use_ozone is true. R=sky@chromium.org, warx@chromium.org BUG=496681 ========== to ========== Fix IsFullScreenMode signature in chrome's fullscreen_ozone.cc Chrome build fails when use_ozone is true. R=sky@chromium.org, warx@chromium.org BUG=496681 Review-Url: https://codereview.chromium.org/2562233002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix IsFullScreenMode signature in chrome's fullscreen_ozone.cc Chrome build fails when use_ozone is true. R=sky@chromium.org, warx@chromium.org BUG=496681 Review-Url: https://codereview.chromium.org/2562233002 ========== to ========== Fix IsFullScreenMode signature in chrome's fullscreen_ozone.cc Chrome build fails when use_ozone is true. R=sky@chromium.org, warx@chromium.org BUG=496681 Committed: https://crrev.com/f468b1ac19374d7e5940e4322648598435265a7e Cr-Commit-Position: refs/heads/master@{#438096} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f468b1ac19374d7e5940e4322648598435265a7e Cr-Commit-Position: refs/heads/master@{#438096} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
