Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2562193002: Add filtering by priority in the Network filter area. (Closed)
Patch Set: Changes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index e62d3fb47c9a37582dc2be94b2989415f41c7d3a..c30bba61b11c9255f308b63c639ca15dac9e7e13 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -162,22 +162,14 @@ Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
return (aScore - bScore) || a._request.indentityCompare(b._request);
}
+ // TODO(allada) This function deserves to be in a network-common of some sort.
/**
* @param {!Network.NetworkDataGridNode} a
* @param {!Network.NetworkDataGridNode} b
* @return {number}
*/
static InitialPriorityComparator(a, b) {
- var priorityMap = Network.NetworkDataGridNode._symbolicToNumericPriority;
- if (!priorityMap) {
- Network.NetworkDataGridNode._symbolicToNumericPriority = new Map();
- priorityMap = Network.NetworkDataGridNode._symbolicToNumericPriority;
- priorityMap.set(Protocol.Network.ResourcePriority.VeryLow, 1);
- priorityMap.set(Protocol.Network.ResourcePriority.Low, 2);
- priorityMap.set(Protocol.Network.ResourcePriority.Medium, 3);
- priorityMap.set(Protocol.Network.ResourcePriority.High, 4);
- priorityMap.set(Protocol.Network.ResourcePriority.VeryHigh, 5);
- }
+ var priorityMap = Components.symbolicToNumericMap();
var aScore = priorityMap.get(a._request.initialPriority()) || 0;
Oleksii Kadurin 2016/12/20 21:13:01 The compiler now complains: WARNING - actual param
var bScore = priorityMap.get(b._request.initialPriority()) || 0;

Powered by Google App Engine
This is Rietveld 408576698