Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js

Issue 2562193002: Add filtering by priority in the Network filter area. (Closed)
Patch Set: Changes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js b/third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js
index a3ea2f88fbe51b00dfcfab29793ec9a8047c696e..78ef7c1d1113cb4e4143de18f781aa5d4681ecba 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js
@@ -80,10 +80,27 @@ Network.FilterSuggestionBuilder = class {
*/
_values(key) {
var result = this._valueLists[key];
allada 2016/12/20 01:35:00 nit: Just to try and help closure catch any future
+
if (!result)
return [];
- result.sort();
+ if (key === Network.NetworkLogView.FilterType.Priority) {
+ var resultSet = new Set(result);
+ result = [];
+ var numericToPriorityMap = Components.symbolicToNumericMap().inverse({regularMap: true});
allada 2016/12/20 01:35:00 Lets replace this with: /** @type {!Map<number, !
+ var sortedNumericPriorities = numericToPriorityMap.keysArray().sortNumbers();
allada 2016/12/20 01:35:00 Lets make this: var sortedNumericPriorities = nume
+ var sortedPriorities = sortedNumericPriorities.map(value => numericToPriorityMap.get(value));
+ var sortedPriorityLabels = sortedPriorities.map(value => Components.uiLabelForPriority(value));
+
+ for (var value of sortedPriorityLabels) {
+ if (!resultSet.has(value))
+ continue;
+ result.push(value);
+ }
+ } else {
+ result.sort();
+ }
+
return result;
}

Powered by Google App Engine
This is Rietveld 408576698