Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

Issue 2562193002: Add filtering by priority in the Network filter area. (Closed)
Patch Set: Changes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js b/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
index fc19d6e08fe92bae648728321f050f37230e72b3..c50a436bcab11a2889e228d7bd629995c81f9015 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
@@ -488,16 +488,61 @@ Components.NetworkConditionsActionDelegate = class {
* @return {string}
*/
Components.uiLabelForPriority = function(priority) {
- var labelMap = Components.uiLabelForPriority._priorityToUILabel;
- if (!labelMap) {
- labelMap = new Map([
- [Protocol.Network.ResourcePriority.VeryLow, Common.UIString('Lowest')],
- [Protocol.Network.ResourcePriority.Low, Common.UIString('Low')],
- [Protocol.Network.ResourcePriority.Medium, Common.UIString('Medium')],
- [Protocol.Network.ResourcePriority.High, Common.UIString('High')],
- [Protocol.Network.ResourcePriority.VeryHigh, Common.UIString('Highest')]
- ]);
- Components.uiLabelForPriority._priorityToUILabel = labelMap;
+ var map = Components.priorityUiLabelMap();
+ return map.get(priority) || Common.UIString('Unknown');
allada 2016/12/20 01:35:00 Lets just return empty string if no match (no need
+};
+
+/**
+ * @param {string} priorityLabel
+ * @return {string}
+ */
+Components.uiLabelToPriority = function(priorityLabel) {
+ var labelToPriorityMap = Components.uiLabelToPriority._uiLabelToPriorityMap;
+
+ if (labelToPriorityMap)
+ return labelToPriorityMap.get(priorityLabel);
+
+ labelToPriorityMap = Components.priorityUiLabelMap().inverse({regularMap: true});
allada 2016/12/20 01:35:00 Lets use: labelToPriorityMap = new Map(); Compone
+ Components.uiLabelToPriority._uiLabelToPriorityMap = labelToPriorityMap;
+ return labelToPriorityMap.get(priorityLabel) || '';
+};
+
+/**
+ * @return {!Map}
allada 2016/12/20 01:35:00 nit: Incomplete definition @return {!Map<!Protoco
+ */
+Components.priorityUiLabelMap = function() {
+ var map = Components.priorityUiLabelMap._priorityUiLabelMap;
+
+ if (map)
+ return map;
+
+ map = new Map([
allada 2016/12/20 01:35:00 nit: I am trying to doctype as much as possible, s
allada 2016/12/20 01:35:00 nit: This code should look similar to the code bel
+ [Protocol.Network.ResourcePriority.VeryLow, Common.UIString('Lowest')],
+ [Protocol.Network.ResourcePriority.Low, Common.UIString('Low')],
+ [Protocol.Network.ResourcePriority.Medium, Common.UIString('Medium')],
+ [Protocol.Network.ResourcePriority.High, Common.UIString('High')],
+ [Protocol.Network.ResourcePriority.VeryHigh, Common.UIString('Highest')]
+ ]);
+ Components.priorityUiLabelMap._priorityUiLabelMap = map;
+
+ return map;
+};
+
+/**
+ * @return {!Map}
allada 2016/12/20 01:35:00 nit: Incomplete definition @return {!Map<!Protoco
+ */
+Components.symbolicToNumericMap = function() {
allada 2016/12/20 01:35:00 Sorry, lets rename this: "prioritySymbolToNumericM
+ var priorityMap = Components.symbolicToNumericMap._symbolicToNumericPriorityMap;
+
+ if (!priorityMap) {
allada 2016/12/20 01:35:00 nit: We use early returns when possible to reduce
+ Components.symbolicToNumericMap._symbolicToNumericPriorityMap = new Map();
allada 2016/12/20 01:35:00 nit: I am trying to doctype as much as possible, s
+ priorityMap = Components.symbolicToNumericMap._symbolicToNumericPriorityMap;
+ priorityMap.set(Protocol.Network.ResourcePriority.VeryLow, 1);
+ priorityMap.set(Protocol.Network.ResourcePriority.Low, 2);
+ priorityMap.set(Protocol.Network.ResourcePriority.Medium, 3);
+ priorityMap.set(Protocol.Network.ResourcePriority.High, 4);
+ priorityMap.set(Protocol.Network.ResourcePriority.VeryHigh, 5);
}
- return labelMap.get(priority) || Common.UIString('Unknown');
+
+ return priorityMap;
};

Powered by Google App Engine
This is Rietveld 408576698