Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2562133002:
Disable all GPU tests on N5X bot temporarily. (Closed)
|
Created:
4 years ago by Jamie Madill Modified:
4 years ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, ynovikov, Stephen White Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable all GPU tests on N5X bot temporarily.
This bot config is having stability problems - disable all tests until
the issue is resolved.
BUG=672502
NOTRY=true
NOPRESUBMIT=true
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/9b5a07979aa2dcfd2698646be9b3c8a6ed6768dd
Cr-Commit-Position: refs/heads/master@{#437676}
Patch Set 1 #
Messages
Total messages: 25 (15 generated)
Description was changed from ========== Disable all GPU tests on N5X bot temporarily. This bot config is having stability problems - disable all tests until the issue is resolved. BUG=672502 R=kbr@chromium.org ========== to ========== Disable all GPU tests on N5X bot temporarily. This bot config is having stability problems - disable all tests until the issue is resolved. BUG=672502 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by jmadill@chromium.org to run a CQ dry run
Description was changed from ========== Disable all GPU tests on N5X bot temporarily. This bot config is having stability problems - disable all tests until the issue is resolved. BUG=672502 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Disable all GPU tests on N5X bot temporarily. This bot config is having stability problems - disable all tests until the issue is resolved. BUG=672502 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Ken, Yuly, PTAL.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I'm not sure how mirroring works, will this also disable the tests on android_optional_gpu_tests_rel and ANGLE CQ? Otherwise, lgtm On Dec 9, 2016 15:34, <jmadill@chromium.org> wrote: > Reviewers: Ken Russell > CL: https://codereview.chromium.org/2562133002/ > > Message: > Ken, Yuly, PTAL. > > Description: > Disable all GPU tests on N5X bot temporarily. > > This bot config is having stability problems - disable all tests until > the issue is resolved. > > BUG=672502 > R=kbr@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux: > linux_optional_gpu_tests_rel;master.tryserver.chromium.mac: > mac_optional_gpu_tests_rel;master.tryserver.chromium.win: > win_optional_gpu_tests_rel;master.tryserver.chromium. > android:android_optional_gpu_tests_rel > > Affected files (+5, -428 lines): > M content/test/gpu/generate_buildbot_json.py > M testing/buildbot/chromium.gpu.fyi.json > > > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
LGTM Yes, this will have the effect of disabling those tests on the tryservers. Both master.tryserver.chromium.angle:android_angle_rel_ng and master.tryserver.chromium.android:android_optional_gpu_tests_rel mirror this waterfall bot. See https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_... .
The CQ bit was unchecked by jmadill@chromium.org
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jmadill@chromium.org
Description was changed from ========== Disable all GPU tests on N5X bot temporarily. This bot config is having stability problems - disable all tests until the issue is resolved. BUG=672502 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Disable all GPU tests on N5X bot temporarily. This bot config is having stability problems - disable all tests until the issue is resolved. BUG=672502 NOTRY=true R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jmadill@chromium.org
The CQ bit was checked by jmadill@chromium.org
Description was changed from ========== Disable all GPU tests on N5X bot temporarily. This bot config is having stability problems - disable all tests until the issue is resolved. BUG=672502 NOTRY=true R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Disable all GPU tests on N5X bot temporarily. This bot config is having stability problems - disable all tests until the issue is resolved. BUG=672502 NOTRY=true NOPRESUBMIT=true R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481324138467050, "parent_rev":
"1c23361eb32d8d661afac9b59681f662ef8ae5b1", "commit_rev":
"2b28da5fa26124b73f66aabf9cb92c975345e9de"}
Message was sent while issue was closed.
Description was changed from ========== Disable all GPU tests on N5X bot temporarily. This bot config is having stability problems - disable all tests until the issue is resolved. BUG=672502 NOTRY=true NOPRESUBMIT=true R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Disable all GPU tests on N5X bot temporarily. This bot config is having stability problems - disable all tests until the issue is resolved. BUG=672502 NOTRY=true NOPRESUBMIT=true R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2562133002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable all GPU tests on N5X bot temporarily. This bot config is having stability problems - disable all tests until the issue is resolved. BUG=672502 NOTRY=true NOPRESUBMIT=true R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2562133002 ========== to ========== Disable all GPU tests on N5X bot temporarily. This bot config is having stability problems - disable all tests until the issue is resolved. BUG=672502 NOTRY=true NOPRESUBMIT=true R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/9b5a07979aa2dcfd2698646be9b3c8a6ed6768dd Cr-Commit-Position: refs/heads/master@{#437676} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9b5a07979aa2dcfd2698646be9b3c8a6ed6768dd Cr-Commit-Position: refs/heads/master@{#437676}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2576853002/ by bpastene@google.com. The reason for reverting is: Flake rate has decreased on the N5X bots. Going to start re-enabling tests..
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2577793002/ by ynovikov@chromium.org. The reason for reverting is: N5X problems might be fixed. Reverting to test that assumption.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
