MD Settings: Bluetooth: Update icon and title to reflect state

MD Settings: Bluetooth: Update icon and title to reflect state

BUG=670431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6a72a9842a33af7080dc97b3d2272cf063b380c8
Cr-Commit-Position: refs/heads/master@{#438628}

[stevenjb, 2016-12-09 18:33:17]

Description was changed from

==========
MD Settings: Bluetooth: Update icon and title to reflect state

BUG=670431
==========

to

==========
MD Settings: Bluetooth: Update icon and title to reflect state

BUG=670431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-12-09 18:52:53]

Patchset #2 (id:20001) has been deleted

[stevenjb, 2016-12-09 18:57:37]

stevenjb@chromium.org changed reviewers:
+ dschuyler@chromium.org, fukino@chromium.org

[dschuyler, 2016-12-13 00:54:43]

https://codereview.chromium.org/2562123002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
(right):

https://codereview.chromium.org/2562123002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html:47: <span
class="middle flex">[[getTitle_(bluetoothEnabled_)]]</span>
IIUC, when the toggle changes, the text for the toggle will also change? Is
changing the text required by UI?

[stevenjb, 2016-12-13 19:22:36]

https://codereview.chromium.org/2562123002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
(right):

https://codereview.chromium.org/2562123002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html:47: <span
class="middle flex">[[getTitle_(bluetoothEnabled_)]]</span>
On 2016/12/13 00:54:43, dschuyler wrote:
> IIUC, when the toggle changes, the text for the toggle will also change? Is
> changing the text required by UI?

See the associated bug, filed by our UX designer :)

[dschuyler, 2016-12-13 19:35:58]

LGTM
(lgtm for the code. I'll followup separately on the label changing with design,
because I think changing the label can lead to confusion).

[stevenjb, 2016-12-13 19:40:32]

On 2016/12/13 19:35:58, dschuyler wrote:
> LGTM
> (lgtm for the code. I'll followup separately on the label changing with
design,
> because I think changing the label can lead to confusion).

sgtm

[stevenjb, 2016-12-14 20:12:41]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-12-14 20:12:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2562123002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-14 20:13:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 21:22:48]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481746361524530,
"parent_rev": "c6ce8fc44481ac7a32225457c1438d505c29c2a6", "commit_rev":
"69ce85ffcdb817a32f3ca8549716aa9d6112a06b"}

[commit-bot: I haz the power, 2016-12-14 21:23:17]

Description was changed from

==========
MD Settings: Bluetooth: Update icon and title to reflect state

BUG=670431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Bluetooth: Update icon and title to reflect state

BUG=670431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2562123002
==========

[commit-bot: I haz the power, 2016-12-14 21:23:18]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-12-14 21:25:47]

Description was changed from

==========
MD Settings: Bluetooth: Update icon and title to reflect state

BUG=670431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2562123002
==========

to

==========
MD Settings: Bluetooth: Update icon and title to reflect state

BUG=670431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6a72a9842a33af7080dc97b3d2272cf063b380c8
Cr-Commit-Position: refs/heads/master@{#438628}
==========

[commit-bot: I haz the power, 2016-12-14 21:25:48]

Patchset 4 (id:??) landed as
https://crrev.com/6a72a9842a33af7080dc97b3d2272cf063b380c8
Cr-Commit-Position: refs/heads/master@{#438628}