Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: components/nacl/renderer/plugin/service_runtime.cc

Issue 2562113003: NaCl plugin: Make ServiceRuntime::Shutdown() kill the NaCl loader (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/nacl/renderer/plugin/service_runtime.h ('k') | components/nacl/renderer/ppb_nacl_private.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/renderer/plugin/service_runtime.cc
diff --git a/components/nacl/renderer/plugin/service_runtime.cc b/components/nacl/renderer/plugin/service_runtime.cc
index 3965e2ef864b936682d263f657aae7589ae3f8e5..de2b6e29ffc20a1b2c8cdd1ff8bf51acebcb3539 100644
--- a/components/nacl/renderer/plugin/service_runtime.cc
+++ b/components/nacl/renderer/plugin/service_runtime.cc
@@ -42,11 +42,12 @@ void ServiceRuntime::StartSelLdr(const SelLdrStartParams& params,
callback.pp_completion_callback());
}
-// TODO(mseaborn): Remove this method, since it is a no-op.
void ServiceRuntime::Shutdown() {
+ nacl::PPBNaClPrivate::TerminateNaClLoader(pp_instance_);
}
ServiceRuntime::~ServiceRuntime() {
+ Shutdown();
}
} // namespace plugin
« no previous file with comments | « components/nacl/renderer/plugin/service_runtime.h ('k') | components/nacl/renderer/ppb_nacl_private.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698