components/nacl/renderer/plugin/service_runtime.h - Issue 2562113003: NaCl plugin: Make ServiceRuntime::Shutdown() kill the NaCl loader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/plugin/service_runtime.h

Issue 2562113003: NaCl plugin: Make ServiceRuntime::Shutdown() kill the NaCl loader (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/renderer/plugin/service_runtime.h

diff --git a/components/nacl/renderer/plugin/service_runtime.h b/components/nacl/renderer/plugin/service_runtime.h

index 7b3da0b754d103977cc0bfa7ec8fc0823564a525..392b9052f34650c75af12040226d393a5e41ddfe 100644

--- a/components/nacl/renderer/plugin/service_runtime.h

+++ b/components/nacl/renderer/plugin/service_runtime.h

@@ -40,6 +40,8 @@ struct SelLdrStartParams {

};

// ServiceRuntime abstracts a NativeClient sel_ldr instance.

+// TODO(dschuff): Merge this with NaClSubprocess, since, that now only contains

+// a ServiceRuntime.

class ServiceRuntime {

public:

ServiceRuntime(Plugin* plugin,