Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2562113002: Fix header guards in //net. (Closed)

Created:
4 years ago by Bence
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri, eroman, kinuko+cache_chromium.org, Paweł Hajdan Jr., fuzzing_chromium.org, mac-reviews_chromium.org, martijn+crwatch_martijnc.be, tbansal+watch-nqe_chromium.org, mmenke, gavinp+disk_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix header guards in //net. * Fix/add header guards in header files in //net except for in //net/third_party and in header files that are meant to be included only with some special macro defined (these are typically *_list.h): + #ifndef FILE_NAME in line 5, + #define FILE_NAME in line 6, + #endif // FILE_NAME in the last line. * Add newline to the end of files that do not already end in a newline. * Remove empty line from the end of files that end in an empty line (that is, remove newline characters down to exactly one newline). * Add empty line between Copyright notice and header guard in net/proxy/dhcpcsvc_init_win.h Committed: https://crrev.com/3698b0a02eb13cc1463779f941f8af0bfd4dbbfe Cr-Commit-Position: refs/heads/master@{#437694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -202 lines) Patch
M net/android/cellular_signal_strength_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/android/dummy_spnego_authenticator.h View 1 chunk +1 line, -1 line 0 comments Download
M net/android/keystore.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/android/legacy_openssl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/android/network_change_notifier_factory_android.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/ip_address.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/linked_hash_map.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/load_timing_info.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/logging_network_change_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_error_details.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/openssl_private_key_store_memory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/port_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/sdch_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/sys_addrinfo.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/base/test_data_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/test_proxy_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/test_proxy_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/cert_net_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/cert_verify_proc_whitelist.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/ct_known_logs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/cert/ct_log_verifier_util.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/ct_policy_enforcer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert/ct_policy_status.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert/ct_serialization_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/cert/internal/nist_pkits_unittest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert/nss_cert_database_chromeos.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert/nss_profile_filter_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/cert/ocsp_revocation_status.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert/ocsp_verify_result.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert/signed_tree_head.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/test_keychain_search_list_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert/x509_certificate_net_log_param.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert_net/cert_net_fetcher_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cookies/parsed_cookie.h View 1 chunk +1 line, -1 line 0 comments Download
M net/der/encode_values.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/net_log_parameters.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/simple/simple_net_log_parameters.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/dns/address_sorter_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/address_sorter_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/dns_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/dns_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/dns_config_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/dns_config_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/dns_config_service_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/dns_config_service_win_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/dns_config_watcher_mac.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/dns/dns_hosts.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/dns_hosts.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/dns_hosts_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/dns_transaction.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/fuzzed_host_resolver.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/dns/serial_worker.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/serial_worker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/serial_worker_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser_unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/ftp/ftp_network_session.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/failing_http_transaction_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_auth_challenge_tokenizer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_cache_lookup_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_log_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_transaction_test_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/mock_gssapi_library_posix.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/mock_gssapi_library_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/log/bounded_file_net_log_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/log/write_to_file_net_log_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/nqe/cached_network_quality.h View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/cached_network_quality.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/effective_connection_type.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/effective_connection_type_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/network_id.h View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/network_qualities_prefs_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/network_quality.h View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/network_quality.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/network_quality_estimator_params.h View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/network_quality_estimator_params.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/network_quality_estimator_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/network_quality_observation.h View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/network_quality_observation_source.h View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/network_quality_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/observation_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/observation_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/socket_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/throughput_analyzer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/throughput_analyzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/weighted_observation.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/dhcpcsvc_init_win.h View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/chromium/crypto/channel_id_chromium.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/mock_quic_data.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/core/quic_sustained_bandwidth_recorder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/platform/impl/quic_export_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/spdy/hpack/hpack_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/hpack/hpack_entry.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/hpack/hpack_header_table.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/hpack/hpack_huffman_table.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/hpack/hpack_input_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/hpack/hpack_output_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/hpack/hpack_static_table.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/http2_priority_dependencies.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/server_push_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_read_queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_session_key.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/ssl/ssl_client_session_cache.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/ssl/test_ssl_private_key.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/test/ct_test_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/test/spawned_test_server/local_test_server_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/spawned_test_server/remote_test_server.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/spawned_test_server/remote_test_server.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/spawned_test_server/spawned_test_server.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/test_certificate_data.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/test/url_request/url_request_hanging_read_job.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/test/url_request/url_request_mock_data_job.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/dns_fuzz_stub/dns_fuzz_stub.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_http_response_cache.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/http_user_agent_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/static_http_user_agent_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/static_http_user_agent_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Bence
Ryan: PTAL. Thank you.
4 years ago (2016-12-09 20:27:25 UTC) #4
Ryan Hamilton
lgtm
4 years ago (2016-12-09 22:56:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562113002/1
4 years ago (2016-12-09 22:56:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 23:37:34 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 14:58:26 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3698b0a02eb13cc1463779f941f8af0bfd4dbbfe
Cr-Commit-Position: refs/heads/master@{#437694}

Powered by Google App Engine
This is Rietveld 408576698