Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2562103002: Add field trial testing config for Scout study. (Closed)

Created:
4 years ago by lpz
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add field trial testing config for Scout study. BUG=648292 Committed: https://crrev.com/9c5e2946272ea6778fbf23596142c7265d452cc4 Cr-Commit-Position: refs/heads/master@{#437640}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +35 lines, -0 lines 1 comment Download

Messages

Total messages: 15 (9 generated)
lpz
4 years ago (2016-12-09 18:13:27 UTC) #4
Nathan Parker
lgtm https://codereview.chromium.org/2562103002/diff/1/testing/variations/fieldtrial_testing_config.json File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2562103002/diff/1/testing/variations/fieldtrial_testing_config.json#newcode1822 testing/variations/fieldtrial_testing_config.json:1822: "name": "CanShowScoutOptInGroup", Last I heard, only the first ...
4 years ago (2016-12-09 18:54:15 UTC) #5
Alexei Svitkine (slow)
lgtm Nathan is correct but in the future we may set up bots to run ...
4 years ago (2016-12-09 19:22:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562103002/1
4 years ago (2016-12-09 20:00:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 20:52:13 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-12 14:40:23 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c5e2946272ea6778fbf23596142c7265d452cc4
Cr-Commit-Position: refs/heads/master@{#437640}

Powered by Google App Engine
This is Rietveld 408576698