Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2562073003:
De-flake HostResolverImplTest.IsIPv6Reachable. (Closed)
DescriptionDe-flake HostResolverImplTest.IsIPv6Reachable.
Previously the test would fail if IsGloballyReachable() took longer
than 1 second.
(The test still has a dependency on some actions executing within a 1
second window, but unlikely to hit it).
BUG=673059
Committed: https://crrev.com/1a17ef38f0fd22d8c297524072b4530cb1a2664a
Cr-Commit-Position: refs/heads/master@{#438373}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by eroman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
eroman@chromium.org changed reviewers: + mmenke@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
LGTM, though if it's taking that long, perhaps it should be done on another thread.
The CQ bit was checked by eroman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Agreed it shouldn't be taking that long. There are two dependent bugs that track the full resolution, but this is a short term solution to prevent flakes for now. I chatted with Ryan about the NSS initialization issue and he explained it was also exacerbated by a recent change on our corp workstation configuration which slowed things down.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by eroman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481673270265550, "parent_rev":
"812f03592ada1ec91928d3e1da9f258b24526c32", "commit_rev":
"1b461fc86446caaa622e07276e62cfa6e4413b70"}
Message was sent while issue was closed.
Description was changed from ========== De-flake HostResolverImplTest.IsIPv6Reachable. Previously the test would fail if IsGloballyReachable() took longer than 1 second. (The test still has a dependency on some actions executing within a 1 second window, but unlikely to hit it). BUG=673059 ========== to ========== De-flake HostResolverImplTest.IsIPv6Reachable. Previously the test would fail if IsGloballyReachable() took longer than 1 second. (The test still has a dependency on some actions executing within a 1 second window, but unlikely to hit it). BUG=673059 Review-Url: https://codereview.chromium.org/2562073003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== De-flake HostResolverImplTest.IsIPv6Reachable. Previously the test would fail if IsGloballyReachable() took longer than 1 second. (The test still has a dependency on some actions executing within a 1 second window, but unlikely to hit it). BUG=673059 Review-Url: https://codereview.chromium.org/2562073003 ========== to ========== De-flake HostResolverImplTest.IsIPv6Reachable. Previously the test would fail if IsGloballyReachable() took longer than 1 second. (The test still has a dependency on some actions executing within a 1 second window, but unlikely to hit it). BUG=673059 Committed: https://crrev.com/1a17ef38f0fd22d8c297524072b4530cb1a2664a Cr-Commit-Position: refs/heads/master@{#438373} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1a17ef38f0fd22d8c297524072b4530cb1a2664a Cr-Commit-Position: refs/heads/master@{#438373} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
