Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: content/browser/frame_host/navigation_controller_impl_browsertest.cc

Issue 2561983002: NavigationController: Reload methods migration (Closed)
Patch Set: android build fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl_browsertest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_browsertest.cc b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
index 4b98ab1516f2c28dd46662533ba0461b03ac2d82..d93d72fb0ac991258a68a3311a1da7c669995a4d 100644
--- a/content/browser/frame_host/navigation_controller_impl_browsertest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
@@ -5077,10 +5077,11 @@ class RenderProcessKilledObserver : public WebContentsObserver {
};
}
-// This tests a race in ReloadOriginalRequest, where a cross-origin reload was
-// causing an in-flight replaceState to look like a cross-origin navigation,
-// even though it's in-page. (The reload should not modify the underlying last
-// committed entry.) Not crashing means that the test is successful.
+// This tests a race in Reload with ReloadType::ORIGINAL_REQUEST_URL, where a
+// cross-origin reload was causing an in-flight replaceState to look like a
+// cross-origin navigation, even though it's in-page. (The reload should not
+// modify the underlying last committed entry.) Not crashing means that the
+// test is successful.
IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest, ReloadOriginalRequest) {
GURL original_url(embedded_test_server()->GetURL(
"/navigation_controller/simple_page_1.html"));
@@ -5090,7 +5091,7 @@ IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest, ReloadOriginalRequest) {
->root();
RenderProcessKilledObserver kill_observer(shell()->web_contents());
- // Redirect so that we can use ReloadOriginalRequest.
+ // Redirect so that we can use Reload with ReloadType::ORIGINAL_REQUEST_URL.
GURL redirect_url(embedded_test_server()->GetURL(
"foo.com", "/navigation_controller/simple_page_1.html"));
{
@@ -5109,16 +5110,17 @@ IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest, ReloadOriginalRequest) {
{
// We first send a replaceState() to the renderer, which will cause the
// renderer to send back a DidCommitProvisionalLoad. Immediately after,
- // we send a ReloadOriginalRequest (which in this case is a different
- // origin) and will also cause the renderer to commit the frame. In the
- // end we verify that both navigations committed and that the URLs are
- // correct.
+ // we send a Reload request with ReloadType::ORIGINAL_REQUEST_URL (which in
+ // this case is a different origin) and will also cause the renderer to
+ // commit the frame. In the end we verify that both navigations committed
+ // and that the URLs are correct.
std::string script = "history.replaceState({}, '', 'foo');";
root->render_manager()
->current_frame_host()
->ExecuteJavaScriptWithUserGestureForTests(base::UTF8ToUTF16(script));
EXPECT_FALSE(shell()->web_contents()->IsLoading());
- shell()->web_contents()->GetController().ReloadOriginalRequestURL(false);
+ shell()->web_contents()->GetController().Reload(
+ false, ReloadType::ORIGINAL_REQUEST_URL);
EXPECT_TRUE(shell()->web_contents()->IsLoading());
EXPECT_EQ(redirect_url, shell()->web_contents()->GetLastCommittedURL());
@@ -6705,16 +6707,16 @@ IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
histogram.ExpectTotalCount(kReloadToReloadMetricName, 0);
histogram.ExpectTotalCount(kReloadMainResourceToReloadMetricName, 0);
- // ReloadBypassingCache triggers a reload of ReloadType::BYPASSING_CACHE.
- // Both metrics should count the consecutive reloads.
- controller.ReloadBypassingCache(false);
+ // Reload with ReloadType::BYPASSING_CACHE. Both metrics should count the
+ // consecutive reloads.
+ controller.Reload(false, ReloadType::BYPASSING_CACHE);
EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));
histogram.ExpectTotalCount(kReloadToReloadMetricName, 1);
histogram.ExpectTotalCount(kReloadMainResourceToReloadMetricName, 1);
- // Triggers another reload of ReloadType::BYPASSING_CACHE.
+ // Triggers another reload with ReloadType::BYPASSING_CACHE.
// ReloadMainResourceToReload should not be counted here.
- controller.ReloadBypassingCache(false);
+ controller.Reload(false, ReloadType::BYPASSING_CACHE);
EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));
histogram.ExpectTotalCount(kReloadToReloadMetricName, 2);
histogram.ExpectTotalCount(kReloadMainResourceToReloadMetricName, 1);

Powered by Google App Engine
This is Rietveld 408576698