Index: content/public/browser/navigation_controller.h |
diff --git a/content/public/browser/navigation_controller.h b/content/public/browser/navigation_controller.h |
index 9c7d8c18d53c409eae905be114a33eeb04e0e61e..af7a529217f990b30e832195a0688013b0befa32 100644 |
--- a/content/public/browser/navigation_controller.h |
+++ b/content/public/browser/navigation_controller.h |
@@ -350,29 +350,12 @@ class NavigationController { |
// the offset is out of bounds. |
virtual void GoToOffset(int offset) = 0; |
- // Reloads the current entry under the specified ReloadType. |
- // TODO(toyoshim): Change all callers to use this new Reload(), and remove |
- // old Reload* methods below. One motivation of this change is Reload(bool) |
- // interface is just confusing because in some contexts, the bool could be to |
- // specify bypassing cache. http://crbug.com/670232 |
- virtual void Reload(bool check_for_repost, ReloadType reload_type) = 0; |
- |
- // Reloads the current entry. If |check_for_repost| is true and the current |
- // entry has POST data the user is prompted to see if they really want to |
- // reload the page. In nearly all cases pass in true. If a transient entry |
- // is showing, initiates a new navigation to its URL. |
- virtual void Reload(bool check_for_repost) = 0; |
- |
- // Like Reload(), but don't use caches (aka "shift-reload"). |
- virtual void ReloadBypassingCache(bool check_for_repost) = 0; |
- |
- // Reloads the current entry using the original URL used to create it. This |
- // is used for cases where the user wants to refresh a page using a different |
- // user agent after following a redirect. |
- virtual void ReloadOriginalRequestURL(bool check_for_repost) = 0; |
- |
- // Like Reload(), but disables Lo-Fi. |
- virtual void ReloadDisableLoFi(bool check_for_repost) = 0; |
+ // Reloads the current entry under the specified ReloadType. If |
+ // |check_for_repost| is true and the current entry has POST data the user is |
+ // prompted to see if they really want to reload the page. In nearly all |
+ // cases pass in true. If a transient entry is showing, initiates a new |
Charlie Reis
2016/12/15 01:32:41
Just curious-- it seems like there's a lot of thes
Takashi Toyoshima
2016/12/15 06:21:52
I think this should be true unless content embedde
Charlie Reis
2016/12/15 18:44:03
Thanks for checking all these!
|
+ // navigation to its URL. |
+ virtual void Reload(ReloadType reload_type, bool check_for_repost) = 0; |
Charlie Reis
2016/12/15 01:32:41
jam@, what are your thoughts on overloads? Would
Takashi Toyoshima
2016/12/15 06:21:52
As I checked, actually there are many valid caller
Charlie Reis
2016/12/15 18:44:03
I was suggesting Plan 3 to get John's thoughts, bu
|
// Removing of entries ------------------------------------------------------- |