chrome/browser/extensions/extension_action_runner.cc - Issue 2561983002: NavigationController: Reload methods migration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_runner.cc

Issue 2561983002: NavigationController: Reload methods migration (Closed)

Patch Set: one more mac build fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_action_runner.cc

diff --git a/chrome/browser/extensions/extension_action_runner.cc b/chrome/browser/extensions/extension_action_runner.cc

index 979f2556104a38460f8e1cd8a81cd81c2755af1d..fdf670b6474ae7f260112ff50f4aa7481ea9bbee 100644

--- a/chrome/browser/extensions/extension_action_runner.cc

+++ b/chrome/browser/extensions/extension_action_runner.cc

@@ -383,7 +383,7 @@ void ExtensionActionRunner::OnBlockedActionBubbleClosed(

->active_tab_permission_granter()

->GrantIfRequested(extension);

}

- web_contents()->GetController().Reload(false);

+ web_contents()->GetController().Reload(content::ReloadType::NORMAL, false);

Takashi Toyoshima 2016/12/15 06:21:51 Probably, there is no case for POST here because w

}