Changed EOverflowAnchor to an enum class and renamed its members

Changed EOverflowAnchor to an enum class and renamed its members

Changed EOverflowAnchor to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflowAnchor to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/ad2fe04892fed522eb67cd054f8696a5cfb1ba3f
Cr-Commit-Position: refs/heads/master@{#438072}

[sashab, 2016-12-09 05:19:00]

Description was changed from

==========
Changed EOverflowAnchor to an enum class and renamed its members

Changed EOverflowAnchor to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflowAnchor to be generated in
ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EOverflowAnchor to an enum class and renamed its members

Changed EOverflowAnchor to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflowAnchor to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[sashab, 2016-12-09 05:19:28]

sashab@chromium.org changed reviewers:
+ napper@chromium.org

[napper, 2016-12-09 05:24:51]

lgtm

[sashab, 2016-12-09 05:25:26]

sashab@chromium.org changed reviewers:
+ nainar@chromium.org

[sashab, 2016-12-09 05:25:27]

nainar@ rs pls

[rune, 2016-12-09 09:06:12]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2016-12-09 09:06:12]

lgtm

[sashab, 2016-12-12 01:54:42]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-12-12 01:54:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 03:23:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 03:23:25]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sashab, 2016-12-13 01:50:08]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:51:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 04:12:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 04:12:46]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sashab, 2016-12-13 04:13:27]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-12-13 04:13:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 06:02:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481602407895010, "parent_rev":
"13c30b0d7cafa19688ff4081385853dec02123d1", "commit_rev":
"153a621920aeee48149e773b858f938bc534a612"}

[commit-bot: I haz the power, 2016-12-13 06:02:59]

Description was changed from

==========
Changed EOverflowAnchor to an enum class and renamed its members

Changed EOverflowAnchor to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflowAnchor to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Changed EOverflowAnchor to an enum class and renamed its members

Changed EOverflowAnchor to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflowAnchor to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2561973002
==========

[commit-bot: I haz the power, 2016-12-13 06:03:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 06:06:41]

Description was changed from

==========
Changed EOverflowAnchor to an enum class and renamed its members

Changed EOverflowAnchor to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflowAnchor to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2561973002
==========

to

==========
Changed EOverflowAnchor to an enum class and renamed its members

Changed EOverflowAnchor to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOverflowAnchor to be generated in
ComputedStyleBase.

BUG=628043
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/ad2fe04892fed522eb67cd054f8696a5cfb1ba3f
Cr-Commit-Position: refs/heads/master@{#438072}
==========

[commit-bot: I haz the power, 2016-12-13 06:06:43]

Patchset 1 (id:??) landed as
https://crrev.com/ad2fe04892fed522eb67cd054f8696a5cfb1ba3f
Cr-Commit-Position: refs/heads/master@{#438072}