Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/base/template_expressions.cc ('K') | « ui/gfx/platform_font_linux.cc ('k') | ui/gfx/win/window_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_harfbuzz.cc
diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc
index e543bc5987583206686d593146fff9e6028f834b..9d72a13f6f318cdb181f0f09ec45b37f3b4b3c4d 100644
--- a/ui/gfx/render_text_harfbuzz.cc
+++ b/ui/gfx/render_text_harfbuzz.cc
@@ -1315,8 +1315,8 @@ void RenderTextHarfBuzz::ItemizeTextToRuns(
const size_t new_run_break = std::min(
static_cast<size_t>(script_item_break),
TextIndexToGivenTextIndex(text, style.GetRange().end()));
- CHECK_GT(new_run_break, run_break)
- << "It must proceed! " << text << " " << run_break;
+ // It must proceed! |text| |run_break|
+ CHECK_GT(new_run_break, run_break);
run_break = new_run_break;
// Break runs at certain characters that need to be rendered separately to
« ui/base/template_expressions.cc ('K') | « ui/gfx/platform_font_linux.cc ('k') | ui/gfx/win/window_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698