Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: ui/gfx/platform_font_linux.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/platform_font_linux.cc
diff --git a/ui/gfx/platform_font_linux.cc b/ui/gfx/platform_font_linux.cc
index 1e741288b422f6c1da1126de42e6f2d1f63dd58a..0d0886a4e645698f8c8e874ab3097c38ce02e504 100644
--- a/ui/gfx/platform_font_linux.cc
+++ b/ui/gfx/platform_font_linux.cc
@@ -60,8 +60,8 @@ sk_sp<SkTypeface> CreateSkTypeface(bool italic,
// scalable font.
typeface = sk_sp<SkTypeface>(SkTypeface::MakeFromName(
kFallbackFontFamilyName, sk_style));
- CHECK(typeface) << "Could not find any font: " << *family << ", "
- << kFallbackFontFamilyName;
+ // Could not find any font.
+ CHECK(typeface);
*family = kFallbackFontFamilyName;
}
return typeface;
@@ -91,8 +91,7 @@ PlatformFontLinux::PlatformFontLinux() {
FontRenderParamsQuery query;
CHECK(FontList::ParseDescription(*default_font_description_,
&query.families, &query.style,
- &query.pixel_size, &query.weight))
- << "Failed to parse font description " << *default_font_description_;
+ &query.pixel_size, &query.weight));
params = gfx::GetFontRenderParams(query, &family);
size_pixels = query.pixel_size;
style = query.style;

Powered by Google App Engine
This is Rietveld 408576698