Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: ui/base/ime/input_method_initializer.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/input_method_initializer.cc
diff --git a/ui/base/ime/input_method_initializer.cc b/ui/base/ime/input_method_initializer.cc
index 1ac3c27aa46fc5af7103d3015315a4b5c6959cc6..c368c5f87f2149bf40901a96cecf81d350128128 100644
--- a/ui/base/ime/input_method_initializer.cc
+++ b/ui/base/ime/input_method_initializer.cc
@@ -43,9 +43,8 @@ void InitializeInputMethodForTesting() {
g_linux_input_method_context_factory = new FakeInputMethodContextFactory();
const LinuxInputMethodContextFactory* factory =
LinuxInputMethodContextFactory::instance();
- CHECK(!factory || factory == g_linux_input_method_context_factory)
- << "LinuxInputMethodContextFactory was already initialized somewhere "
- << "else.";
+ // LinuxInputMethodContextFactory was already initialized somewhere else.
+ CHECK(!factory || factory == g_linux_input_method_context_factory);
LinuxInputMethodContextFactory::SetInstance(
g_linux_input_method_context_factory);
#endif
@@ -57,8 +56,8 @@ void ShutdownInputMethodForTesting() {
#elif defined(USE_AURA) && defined(OS_LINUX)
const LinuxInputMethodContextFactory* factory =
LinuxInputMethodContextFactory::instance();
- CHECK(!factory || factory == g_linux_input_method_context_factory)
- << "An unknown LinuxInputMethodContextFactory was set.";
+ // An unknown LinuxInputMethodContextFactory was set.
+ CHECK(!factory || factory == g_linux_input_method_context_factory);
LinuxInputMethodContextFactory::SetInstance(NULL);
delete g_linux_input_method_context_factory;
g_linux_input_method_context_factory = NULL;

Powered by Google App Engine
This is Rietveld 408576698