Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: tools/json_schema_compiler/test/test_util.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/test_util.cc
diff --git a/tools/json_schema_compiler/test/test_util.cc b/tools/json_schema_compiler/test/test_util.cc
index 60744ba57b2e27297a01f93dacf72a9cfa18ce71..8e3cce2f487ab5fd4db287df702332a3882459f8 100644
--- a/tools/json_schema_compiler/test/test_util.cc
+++ b/tools/json_schema_compiler/test/test_util.cc
@@ -18,8 +18,8 @@ std::unique_ptr<base::Value> ReadJson(const base::StringPiece& json) {
std::string error_msg;
std::unique_ptr<base::Value> result(base::JSONReader::ReadAndReturnError(
json, base::JSON_ALLOW_TRAILING_COMMAS, &error_code, &error_msg));
- // CHECK not ASSERT since passing invalid |json| is a test error.
- CHECK(result) << error_msg;
+ // Crash on failure since passing invalid |json| is a test error.
+ LOG_IF(FATAL, !result) << error_msg;
return result;
}

Powered by Google App Engine
This is Rietveld 408576698