third_party/crashpad/crashpad/util/stdlib/string_number_conversion.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/util/stdlib/string_number_conversion.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/host/curtain_mode_mac.cc ('K') | « third_party/crashpad/crashpad/util/posix/drop_privileges.cc ('k') | third_party/crashpad/crashpad/util/synchronization/semaphore_mac.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/util/stdlib/string_number_conversion.cc

diff --git a/third_party/crashpad/crashpad/util/stdlib/string_number_conversion.cc b/third_party/crashpad/crashpad/util/stdlib/string_number_conversion.cc

index 65d5a63278c4d39acf3ee68666cb65b1410663e6..6421fa0d387d4221396d57a0ab6a9279d9dd8bd6 100644

--- a/third_party/crashpad/crashpad/util/stdlib/string_number_conversion.cc

+++ b/third_party/crashpad/crashpad/util/stdlib/string_number_conversion.cc

@@ -34,7 +34,7 @@

#define CONSTEXPR_STATIC_ASSERT(condition, message) \

static_assert(condition, message)

#else

-#define CONSTEXPR_STATIC_ASSERT(condition, message) CHECK(condition) << message

+#define CONSTEXPR_STATIC_ASSERT(condition, message) CHECK(condition)

#endif

namespace {