Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/crashpad/crashpad/test/errors.h

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/host/curtain_mode_mac.cc ('K') | « third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_simple_annotations.cc ('k') | third_party/crashpad/crashpad/test/paths_win.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/crashpad/crashpad/test/errors.h
diff --git a/third_party/crashpad/crashpad/test/errors.h b/third_party/crashpad/crashpad/test/errors.h
index 17b0bea62d3adfd35d7c6e8036cb601682733587..bd1ba9ef168c005fdeb42ccc1818cceef0b5dbb6 100644
--- a/third_party/crashpad/crashpad/test/errors.h
+++ b/third_party/crashpad/crashpad/test/errors.h
@@ -28,7 +28,8 @@ namespace test {
// to.
//
// Where non-test code could do:
-// PCHECK(rv == 0) << "close";
+// // close
+CHECK(rv == 0);
// gtest-based test code can do:
// EXPECT_EQ(0, rv) << ErrnoMessage("close");
« remoting/host/curtain_mode_mac.cc ('K') | « third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_simple_annotations.cc ('k') | third_party/crashpad/crashpad/test/paths_win.cc » ('j') | ui/base/template_expressions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698