Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_image_reader.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_image_reader.cc
diff --git a/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_image_reader.cc b/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_image_reader.cc
index a114d392e16c89962ef53501d96b5e091a695fca..5ba876134daf1a58ee82018becb146240900de65 100644
--- a/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_image_reader.cc
+++ b/third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_image_reader.cc
@@ -38,8 +38,8 @@ int wmain(int argc, wchar_t* argv[]) {
crashpad::ScopedKernelHANDLE done(CreateEvent(nullptr, true, false, argv[1]));
- PCHECK(LoadLibrary(L"crashpad_snapshot_test_image_reader_module.dll"))
- << "LoadLibrary";
+ // LoadLibrary
+ CHECK(LoadLibrary(L"crashpad_snapshot_test_image_reader_module.dll"));
// Create threads with lots of stack pointers to memory. This is used to
// verify the cap on pointed-to memory.
@@ -75,7 +75,8 @@ int wmain(int argc, wchar_t* argv[]) {
// Tell the parent process we're ready to proceed.
HANDLE out = GetStdHandle(STD_OUTPUT_HANDLE);
- PCHECK(out != INVALID_HANDLE_VALUE) << "GetStdHandle";
+ // GetStdHandle
+ CHECK(out != INVALID_HANDLE_VALUE);
char c = ' ';
crashpad::CheckedWriteFile(out, &c, sizeof(c));

Powered by Google App Engine
This is Rietveld 408576698