Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: services/service_manager/runner/host/child_process_host.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/runner/host/child_process_host.cc
diff --git a/services/service_manager/runner/host/child_process_host.cc b/services/service_manager/runner/host/child_process_host.cc
index 4f1de535b57c569d4079c446c343603f5ee02ecb..a701e3f982facdfa386aa8b53ea9cfb34ea64628 100644
--- a/services/service_manager/runner/host/child_process_host.cc
+++ b/services/service_manager/runner/host/child_process_host.cc
@@ -58,8 +58,8 @@ ChildProcessHost::ChildProcessHost(base::TaskRunner* launch_process_runner,
ChildProcessHost::~ChildProcessHost() {
if (!app_path_.empty()) {
- CHECK(!mojo_ipc_channel_)
- << "Destroying ChildProcessHost before calling Join";
+ // Destroying ChildProcessHost before calling Join
+ CHECK(!mojo_ipc_channel_);
}
}
@@ -143,7 +143,8 @@ void ChildProcessHost::DoLaunch(
#if defined(OS_WIN)
options.handles_to_inherit = &handle_passing_info_;
#if defined(OFFICIAL_BUILD)
- CHECK(false) << "Launching mojo process with inherit_handles is insecure!";
+ // Launching mojo process with inherit_handles is insecure!
+ CHECK(false);
#endif
options.inherit_handles = true;
options.stdin_handle = INVALID_HANDLE_VALUE;

Powered by Google App Engine
This is Rietveld 408576698