Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: sandbox/linux/services/scoped_process.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sandbox/linux/services/scoped_process.cc
diff --git a/sandbox/linux/services/scoped_process.cc b/sandbox/linux/services/scoped_process.cc
index 65af4873a441cbea6631ae538afd841411e1332f..dc60c532ffae024259dced480dcf4f9e5abcc839 100644
--- a/sandbox/linux/services/scoped_process.cc
+++ b/sandbox/linux/services/scoped_process.cc
@@ -82,7 +82,8 @@ int ScopedProcess::WaitForExit(bool* got_signaled) {
// WNOWAIT to make sure that the destructor can wait on the child.
int ret = HANDLE_EINTR(
waitid(P_PID, child_process_id_, &process_info, WEXITED | WNOWAIT));
- PCHECK(0 == ret) << "Did something else wait on the child?";
+ // Did something else wait on the child?
+ CHECK(0 == ret);
if (process_info.si_code == CLD_EXITED) {
*got_signaled = false;
@@ -90,8 +91,8 @@ int ScopedProcess::WaitForExit(bool* got_signaled) {
process_info.si_code == CLD_DUMPED) {
*got_signaled = true;
} else {
- CHECK(false) << "ScopedProcess needs to be extended for si_code "
- << process_info.si_code;
+ // ScopedProcess needs to be extended for si_code |process_info.si_code|
+ CHECK(false);
}
return process_info.si_status;
}

Powered by Google App Engine
This is Rietveld 408576698