Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Unified Diff: remoting/host/remoting_me2me_host.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/remoting_me2me_host.cc
diff --git a/remoting/host/remoting_me2me_host.cc b/remoting/host/remoting_me2me_host.cc
index aca4bc9d03514abd0c8b559c9220f375925169ea..205ecc5faa2e1256cac7bcbdf96ea4cef9ff5482 100644
--- a/remoting/host/remoting_me2me_host.cc
+++ b/remoting/host/remoting_me2me_host.cc
@@ -772,7 +772,8 @@ bool HostProcess::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
- CHECK(handled) << "Received unexpected IPC type: " << message.type();
+ // Received unexpected IPC type.
+ CHECK(handled);
return handled;
#else // !defined(REMOTING_MULTI_PROCESS)
@@ -1613,7 +1614,7 @@ void HostProcess::OnCrash(const std::string& function_name,
base::debug::Alias(message);
// The daemon requested us to crash the process.
- CHECK(false) << message;
+ LOG(FATAL) << message;
}
int HostProcessMain() {

Powered by Google App Engine
This is Rietveld 408576698