Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2876)

Unified Diff: blimp/engine/renderer/blob_channel_sender_proxy.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/renderer/blob_channel_sender_proxy.cc
diff --git a/blimp/engine/renderer/blob_channel_sender_proxy.cc b/blimp/engine/renderer/blob_channel_sender_proxy.cc
index ba62580ed3cea401954409d97a9593e268bce5f3..3d200c472702d203241a8ebf0bdabd81691ac008 100644
--- a/blimp/engine/renderer/blob_channel_sender_proxy.cc
+++ b/blimp/engine/renderer/blob_channel_sender_proxy.cc
@@ -19,7 +19,8 @@ mojom::BlobChannelPtr GetConnectedBlobChannel() {
mojom::BlobChannelPtr blob_channel_ptr;
content::RenderThread::Get()->GetRemoteInterfaces()->GetInterface(
&blob_channel_ptr);
- CHECK(blob_channel_ptr) << "Could not connect to BlobChannel Mojo interface.";
+ // Could not connect to BlobChannel Mojo interface.
+ CHECK(blob_channel_ptr);
return blob_channel_ptr;
}
@@ -54,8 +55,8 @@ SharedMemoryBlob::~SharedMemoryBlob() {}
mojo::ScopedSharedBufferHandle SharedMemoryBlob::CreateRemoteHandle() {
mojo::ScopedSharedBufferHandle remote_handle =
local_handle_->Clone(mojo::SharedBufferHandle::AccessMode::READ_ONLY);
- CHECK(remote_handle.is_valid())
- << "Mojo error when creating read-only buffer handle.";
+ // Mojo error when creating read-only buffer handle.
+ CHECK(remote_handle.is_valid());
return remote_handle;
}
@@ -93,7 +94,8 @@ void BlobChannelSenderProxy::PutBlob(const BlobId& id, BlobDataPtr data) {
DCHECK(!IsInEngineCache(id));
size_t size = data->data.size();
- CHECK(!data->data.empty()) << "Zero length blob sent: " << BlobIdToString(id);
+ // Zero length blob sent.
+ CHECK(!data->data.empty());
replication_state_[id] = false;
std::unique_ptr<SharedMemoryBlob> shared_mem_blob(

Powered by Google App Engine
This is Rietveld 408576698