Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: base/logging_unittest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/logging_unittest.cc
diff --git a/base/logging_unittest.cc b/base/logging_unittest.cc
index f41cce2f43b390fa9603a14f3f689fe87d0dcb33..e73b00aabde63e9e929e3281f522ab2405b7add3 100644
--- a/base/logging_unittest.cc
+++ b/base/logging_unittest.cc
@@ -180,12 +180,10 @@ TEST_F(LoggingTest, CheckStreamsAreLazy) {
SetLogAssertHandler(&LogSink);
- CHECK(mock_log_source.Log()) << uncalled_mock_log_source.Log();
- PCHECK(!mock_log_source.Log()) << mock_log_source.Log();
- CHECK_EQ(mock_log_source.Log(), mock_log_source.Log())
- << uncalled_mock_log_source.Log();
- CHECK_NE(mock_log_source.Log(), mock_log_source.Log())
- << mock_log_source.Log();
+ CHECK(mock_log_source.Log());
+ CHECK(!mock_log_source.Log());
+ CHECK_EQ(mock_log_source.Log(), mock_log_source.Log());
+ CHECK_NE(mock_log_source.Log(), mock_log_source.Log());
}
#endif

Powered by Google App Engine
This is Rietveld 408576698