Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3319)

Unified Diff: ash/test/ash_test_base.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/test/ash_test_base.cc
diff --git a/ash/test/ash_test_base.cc b/ash/test/ash_test_base.cc
index 5b1d9bcd5e22af49493f2819064edd477f01d9ba..40ed0346769dff9e8dd86f9219b4d8a3dadded8b 100644
--- a/ash/test/ash_test_base.cc
+++ b/ash/test/ash_test_base.cc
@@ -113,10 +113,10 @@ AshTestBase::AshTestBase()
}
AshTestBase::~AshTestBase() {
- CHECK(setup_called_)
- << "You have overridden SetUp but never called AshTestBase::SetUp";
- CHECK(teardown_called_)
- << "You have overridden TearDown but never called AshTestBase::TearDown";
+ // You have overridden SetUp but never called AshTestBase::SetUp
+ CHECK(setup_called_);
+ // You have overridden TearDown but never called AshTestBase::TearDown
+ CHECK(teardown_called_);
}
void AshTestBase::SetUp() {

Powered by Google App Engine
This is Rietveld 408576698