Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2561913003: Create a QUIC wrapper around a mutex and a mutex lock. (Closed)

Created:
4 years ago by Fan Yang
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create a QUIC wrapper around a mutex and a mutex lock. Merge internal change: 141451848 Committed: https://crrev.com/1e1066e9bacc6920e2b73a67d4c93b7ccecaa2a4 Cr-Commit-Position: refs/heads/master@{#437734}

Patch Set 1 #

Patch Set 2 : remove 2 headers #

Total comments: 1

Patch Set 3 : fix win compile error #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -72 lines) Patch
M net/net.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/crypto/crypto_secret_boxer.h View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/core/crypto/crypto_secret_boxer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/local_strike_register_client.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/crypto/local_strike_register_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 1 3 chunks +7 lines, -6 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 11 chunks +18 lines, -12 lines 0 comments Download
A net/quic/platform/api/quic_mutex.h View 1 chunk +70 lines, -0 lines 0 comments Download
A net/quic/platform/api/quic_mutex.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A net/quic/platform/impl/quic_mutex_impl.h View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download
A net/quic/platform/impl/quic_mutex_impl.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_crypto_server_config_peer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_http_response_cache.h View 2 chunks +7 lines, -4 lines 0 comments Download
M net/tools/quic/quic_http_response_cache.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.h View 5 chunks +14 lines, -14 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_server.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/tools/quic/test_tools/server_thread.h View 2 chunks +4 lines, -3 lines 0 comments Download
M net/tools/quic/test_tools/server_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (21 generated)
Fan Yang
4 years ago (2016-12-09 20:43:28 UTC) #8
Ryan Hamilton
lgtm YAYAYAYAY! LGTM. One comment to address in a follow up. https://codereview.chromium.org/2561913003/diff/60001/net/quic/platform/impl/quic_mutex_impl.cc File net/quic/platform/impl/quic_mutex_impl.cc (right): ...
4 years ago (2016-12-09 22:02:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561913003/60001
4 years ago (2016-12-09 22:03:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561913003/100001
4 years ago (2016-12-10 02:45:45 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years ago (2016-12-10 02:53:33 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-12 15:05:46 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1e1066e9bacc6920e2b73a67d4c93b7ccecaa2a4
Cr-Commit-Position: refs/heads/master@{#437734}

Powered by Google App Engine
This is Rietveld 408576698